-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PaddlePaddle Hackathon 4】add paddle flip op #15828
【PaddlePaddle Hackathon 4】add paddle flip op #15828
Conversation
d8ba030
to
caf6038
Compare
ecc0c9d
to
eab9455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment left. Other LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, but would like to see approve from @ceciliapeng2011
@ceciliapeng2011 PTAL |
@ceciliapeng2011 PTAL |
@OpenVINO-dev-contest PTAL |
@ceciliapeng2011 could you please review? |
Can one of the admins verify this patch? |
As I can see, Reverse op was deleted in opset2. We don't have this operator in opset2+ |
PD reverse op executes the same operation. It is better to unify the two mappings instead of two separate implement. |
Yes, I agree. But the current pd reverse op translator uses OV Reverse op that was deleted from officially supported opsets (from opset2 and later). We need to fix reverse op translator in this case |
@Asthestarsfalll Hi, it is much appreciated if you can help unify |
I will update code latter. |
Head branch was pushed to by a user without write access
Details:
add flip operation in Paddle front end
Tickets:
Reference:
https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/flip_en.html
https://github.com/PaddlePaddle/Paddle/blob/release/2.4/python/paddle/tensor/manipulation.py#L1327
https://github.com/PaddlePaddle/Paddle2ONNX/blob/develop/paddle2onnx/legacy/op_mapper/tensor.py#L2018
Test Result