Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable deformable_detr for PDFE #17525

Merged
merged 3 commits into from
Aug 30, 2023
Merged

enable deformable_detr for PDFE #17525

merged 3 commits into from
Aug 30, 2023

Conversation

xczhai
Copy link
Contributor

@xczhai xczhai commented May 15, 2023 •
edited
Loading

Details:

@xczhai xczhai requested review from a team as code owners May 15, 2023 01:41
@xczhai xczhai requested review from kblaszczak-intel and removed request for a team May 15, 2023 01:41
@github-actions github-actions bot added category: docs OpenVINO documentation category: PDPD FE OpenVINO PaddlePaddle FrontEnd labels May 15, 2023
@xczhai xczhai mentioned this pull request May 15, 2023
Closed
@yuxu42 yuxu42 requested a review from meiyang-intel May 15, 2023 02:07
@xczhai xczhai force-pushed the pd_enable_sin_and_cos branch 2 times, most recently from 7614cbb to 0b2b3a0 Compare May 16, 2023 01:55
@xczhai xczhai changed the title enable sin and cos in PDFE enable deformable_detr for PDFE May 16, 2023
@alanzhai219 alanzhai219 mentioned this pull request May 18, 2023
Merged
@github-actions github-actions bot removed the category: docs OpenVINO documentation label May 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 6, 2023
meiyang-intel
meiyang-intel reviewed Jun 6, 2023
View reviewed changes
src/frontends/paddle/tests/test_models/gen_scripts/generate_cos.py Outdated
return outs[0]

def main():
x = np.random.rand(8, 24, 32).astype(data_type)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to expand the value range of input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to expand the value range of input

update it.

This was referenced Jun 8, 2023
Closed
Closed
@github-actions github-actions bot removed the Stale label Jun 28, 2023
@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 12, 2023
@yuxu42
Copy link
Contributor

yuxu42 commented Jul 12, 2023

@ceciliapeng2011 Could you please take a review? Thanks!

ceciliapeng2011
ceciliapeng2011 reviewed Jul 12, 2023
View reviewed changes
src/frontends/paddle/src/op/top_k_v2.cpp
@@ -27,7 +27,7 @@ NamedOutputs top_k_v2(const NodeContext& node) {
std::string sort_type = sorted ? "value" : "none";
std::string mode = largest ? "max" : "min";

auto node_topk = std::make_shared<default_opset::TopK>(x, k_expected_node, axis, mode, sort_type);
auto node_topk = std::make_shared<default_opset::TopK>(x, k_expected_node, axis, mode, sort_type, element::i64);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`Why do we have to fix the type to i64? Is it possible to be i32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ceciliapeng2011

@ceciliapeng2011 ceciliapeng2011 self-assigned this Jul 12, 2023
@github-actions github-actions bot removed the Stale label Jul 13, 2023
@yuxu42
Copy link
Contributor

yuxu42 commented Jul 18, 2023

@ceciliapeng2011 can we merge?

@xczhai
Copy link
Contributor Author

xczhai commented Jul 27, 2023

@ceciliapeng2011 could you help merge this PR?

@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Aug 11, 2023
@github-actions github-actions bot removed the Stale label Aug 12, 2023
@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Aug 27, 2023
@yuxu42
Copy link
Contributor

yuxu42 commented Aug 28, 2023

@xczhai Could you please fix the CI issue and proceed the PR merege? Thanks!

@xczhai xczhai force-pushed the pd_enable_sin_and_cos branch 2 times, most recently from 5d8cd70 to 38f4dcf Compare August 28, 2023 03:17
@xczhai
Copy link
Contributor Author

xczhai commented Aug 28, 2023

@xczhai Could you please fix the CI issue and proceed the PR merege? Thanks!

Yes. fixed it.

@xczhai xczhai force-pushed the pd_enable_sin_and_cos branch 3 times, most recently from 418d38a to b9be789 Compare August 28, 2023 07:48
@xczhai xczhai requested a review from a team as a code owner August 28, 2023 07:48
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Aug 28, 2023
@github-actions github-actions bot removed category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Aug 28, 2023
@github-actions github-actions bot removed the Stale label Aug 29, 2023
@ceciliapeng2011 ceciliapeng2011 merged commit 36b9de1 into openvinotoolkit:master Aug 30, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiyang-intel meiyang-intel meiyang-intel approved these changes

@ceciliapeng2011 ceciliapeng2011 ceciliapeng2011 approved these changes

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel was automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees

@ceciliapeng2011 ceciliapeng2011

Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xczhai @yuxu42 @ceciliapeng2011 @meiyang-intel