Skip to content

Conversation

@razvanapetroaie
Copy link
Contributor

@razvanapetroaie razvanapetroaie commented Nov 28, 2025

Details:

  • The new model marshalling algorithm is not handling subgraphs properly. See this code passage: the attribute is added only on ov::Constant nodes found at depth level one. Models within models, which may be registered as "subgraph operators" (e.g. TensorIterator) are omitted. In this current state, the attribute is required on all constant nodes, otherwise the run will fail at the deserialization stage.
  • As a temporary fix to unblock this PR, all constant nodes that have been omitted will have their weights copied in a separate buffer. We may consider this a safety measure for now, with no real impact on performance. The impact can be great if, say, a model has a huge submodel within it, but the data we've gathered so far suggests these cases are not frequent (none of our models from the CI validation jobs use this feature).

Tickets:

@razvanapetroaie razvanapetroaie requested review from a team as code owners November 28, 2025 11:24
@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Nov 28, 2025
@razvanapetroaie razvanapetroaie added this pull request to the merge queue Nov 28, 2025
Merged via the queue into openvinotoolkit:master with commit 45921fa Nov 28, 2025
187 of 193 checks passed
@razvanapetroaie razvanapetroaie deleted the CVS-177414-marshalling-handle-subgraphs branch November 28, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: NPU OpenVINO NPU plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants