Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run integration tests on correct file changes #3230

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Sep 12, 2024

Only runs the integration tests when there is changes that should be tested.

Scenario Tests:

  • scenarios or aries-cloudagent or poetry.lock directories change

BDD Integration Tests:

  • demo or aries-cloudagent or poetry.lock directories change

BDD Interop Tests:

  • aries-cloudagent or poetry.lock directory change

This is to speed things up and not put as much load on the remote test resources. Possibly, we could also stop running the unit tests for non-code changes. Although then the sonarcloud scan wouldn't run on it.

Signed-off-by: Jamie Hale <jamiehalebc@gmail.com>
@jamshale jamshale marked this pull request as ready for review September 12, 2024 20:08
@jamshale jamshale marked this pull request as draft September 12, 2024 20:09
Signed-off-by: Jamie Hale <jamiehalebc@gmail.com>
@jamshale jamshale marked this pull request as ready for review September 12, 2024 20:16
Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamshale jamshale enabled auto-merge (squash) September 16, 2024 17:48
@jamshale jamshale merged commit 1de2178 into openwallet-foundation:main Sep 16, 2024
10 checks passed
Copy link

sonarcloud bot commented Sep 16, 2024

ff137 pushed a commit to ff137/acapy that referenced this pull request Oct 22, 2024
…tion#3230)

* Only run integration tests on correct file changes

Signed-off-by: Jamie Hale <jamiehalebc@gmail.com>

* Run tests on poetry.lock changes

Signed-off-by: Jamie Hale <jamiehalebc@gmail.com>

---------

Signed-off-by: Jamie Hale <jamiehalebc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only run the integration test suite on source code or testing changes.
2 participants