Fix #427 websocket --admin-api-key connect issue #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 237 237
Lines 12180 12202 +22
=======================================
+ Hits 11715 11737 +22
Misses 465 465 |
This is the proposed option number 2. It uses the websocket to expect a message with the admin api key before it is being used to transmit any other messages than 'ping' Signed-off-by: Matthias Binzer <matthias.binzer.ext@bosch.com>
|
This was merged as part of #570 because it needed rebasing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed option number 2. It uses the websocket
to expect a message with the admin api key before it is being
used to transmit any other messages than 'ping'
Signed-off-by: Matthias Binzer matthias.binzer.ext@bosch.com