[ROCM] Fix gpu_kernel_test #25388
Closed
[ROCM] Fix gpu_kernel_test #25388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekstheod
force-pushed
the
ci_fix_gpu_kernel_test
branch
from
73f7000 to
2c127b7
Compare
alekstheod
force-pushed
the
ci_fix_gpu_kernel_test
branch
from
2c127b7 to
37540db
Compare
akuegel
approved these changes
Apr 22, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR #25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=#25388 from ROCm:ci_fix_gpu_kernel_test 37540db PiperOrigin-RevId: 750100342
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db7cd36d668996ce6b01ac16cad122c463f by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 750100342
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR #25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=#25388 from ROCm:ci_fix_gpu_kernel_test 37540db PiperOrigin-RevId: 750102076
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db7cd36d668996ce6b01ac16cad122c463f by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 750102076
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR #25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=#25388 from ROCm:ci_fix_gpu_kernel_test 37540db PiperOrigin-RevId: 750102076
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db7cd36d668996ce6b01ac16cad122c463f by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 750100342
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR #25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=#25388 from ROCm:ci_fix_gpu_kernel_test 37540db PiperOrigin-RevId: 750100342
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db7cd36d668996ce6b01ac16cad122c463f by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 750102076
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db7cd36d668996ce6b01ac16cad122c463f by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 750100342
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 750108982
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
…er in latency_hiding_scheduler, so that we can potentially reuse them across different users without needing to re-construct new ones. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 747709188
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
This means the cub_sort_thunk and the sort_rewriter won't directly depend on the CUB implementation anymore. Instead they go through the FFI registry. This decouples CUDA and ROCm implementations of CUB from the users of CUB and will also help with splitting the compiler from the runtime. This also removes the requirement for having a stub for SortRewriter. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 745027614
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25388 Fix failed test in ROCM CI build. Copybara import of the project: -- 37540db7cd36d668996ce6b01ac16cad122c463f by alekstheod <atheodor@amd.com>: Fix gpu_kernel_test Merging this change closes #25388 PiperOrigin-RevId: 750128132
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25388 from ROCm:ci_fix_gpu_kernel_test 37540db7cd36d668996ce6b01ac16cad122c463f PiperOrigin-RevId: 747850223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failed test in ROCM CI build.