Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Linux: describe ed25519 support #131

Closed

Conversation

ejiektpobehuk
Copy link
Contributor

ed25519 support: mkj/dropbear#91

@rlaager rlaager assigned rlaager and unassigned rlaager Mar 7, 2021
@rlaager
Copy link
Member

rlaager commented Mar 7, 2021

@ejiek Could you add a Signed-off-by to the commit, please?

@ne9z Is this support now available in Arch?

@ghost
Copy link

ghost commented Mar 8, 2021

@ejiek Have you tested this though? Last time I checked, mkinitcpio-dropbear hook complains a lot for not being able to read ed25519 host key generated with ssh-keygen -Am pem. For now I would just stick with good ol' RSA 3072 keys.

@ejiektpobehuk
Copy link
Contributor Author

@ne9z @rlaager this setup works a fresh install of AL (as of 07.03.2021).

I've experienced no problems with ed25519 key in /etc/dropbear/root_key.
As for host keys dropbearconvert openssh dropbear /etc/ssh/ssh_host_ed25519_key dropbear_ed25519_host_key has succesfully converted a host key, but it's not done by mkinitcpio-dropbear hook yet.

@ejiektpobehuk ejiektpobehuk force-pushed the AL_dropbear_ed25519 branch 2 times, most recently from 2916fdc to 36efa7f Compare March 9, 2021 10:15
@ghost
Copy link

ghost commented Mar 9, 2021

Thanks for testing this out. So it means that ed25519 still does not work with mkinitcpio-dropbear without manually converting the host key first.

Please add this instruction and note to the pull request.

@ejiektpobehuk
Copy link
Contributor Author

I'd argue that this PR was about /etc/dropbear/root_key not a host key.
But I think that it can be expanded to ed25519 support =]

@ejiektpobehuk ejiektpobehuk changed the title Arch Linux: Remove DropBear key limitation note Arch Linux: describe ed25519 support Mar 23, 2021
@ghost
Copy link

ghost commented Mar 23, 2021

Latest commit looks good to me. However Arch guide has significantly changed since this notice was proposed. "This branch has conflicts that must be resolved"

Maybe rebase on the latest version?

ed25519 support: mkj/dropbear#91

Signed-off-by: Vlad Petrov <ejiek@mail.ru>
@ejiektpobehuk
Copy link
Contributor Author

Done!

I'm not sure how correct it is in English but I've added two commas to make reading a bit easier.

Thanks for all the support during this PR!

@ghost
Copy link

ghost commented Mar 23, 2021

I've opened a pull request in your repo to address the issues.

Signed-off-by: Maurice Zhou <ja@apvc.uk>
@ghost
Copy link

ghost commented Mar 24, 2021

@rlaager I think it's ready for merging.

@rlaager rlaager closed this in 8a996a1 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants