This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Introduced spl_dirname function. #649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 8bcb77fabd7cbabcad49f58750be8683febee92b in kernel tree the logic for getting parent path doesn't work. The parent points to the file itself instead of its parent path. This results that the cache file for pool is never removed. The new function returns parent directory where the file is placed. Then kern_path is executed with the parent directory name and the LOOKUP_DIR flag. Returned parent structure will point to correct parent path. Signed-off-by: Arkadiusz Bubała <arkadiusz.bubala@open-e.com>
behlendorf
reviewed
Oct 11, 2017
There was a problem hiding this comment.
@ab-oe sorry I lost track of this one. These functions have been historically problematic and very lightly used. Perhaps the best thing to do here is outright remove them rather than patch them again. What do you think of this for an alternate fix, openzfs/zfs#6753
| if (!dirname) | ||
| return (ERR_PTR(-ENOMEM)); | ||
|
|
||
| rc = kern_path(dirname, LOOKUP_DIR, &parent); | ||
| if (rc) |
There was a problem hiding this comment.
dirname will be leaked in this error path.
There was a problem hiding this comment.
Thank you. You're right the kfree should be put before the if condition.
|
Closing. Replaced by #661 where this functionality is removed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 8bcb77fabd7cbabcad49f58750be8683febee92b in kernel tree the logic for getting parent path doesn't work. The parent points to the file itself instead of its parent path. This results that the cache file for pool is never removed.
The new function returns parent directory where the file is placed. Then kern_path is executed with the parent directory name and the LOOKUP_DIR flag. Returned parent structure will point to correct
parent path.
Addresses: #648