Skip to content

Commit

Permalink
Add all read-only compatible features to GRUB2 compatibility feature set
Browse files Browse the repository at this point in the history
Since GRUB2 opens pools in read-only mode, all read-only compatible
features can be enabled.

Several read-only compatible features have been introduced since the
GRUB2 compatibility file was created but the file wasn't updated.

I added all features from `zpool_feature_init()` in
`module/zcommon/zfeature_common.c` where the
`ZFEATURE_FLAG_READONLY_COMPAT` flag is set.

Signed-off-by: Luflosi <luflosi@luflosi.de>
  • Loading branch information
Luflosi committed Mar 27, 2023
1 parent a05263b commit 583ebc6
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
12 changes: 12 additions & 0 deletions cmd/zpool/compatibility.d/grub2
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
# Features which are supported by GRUB2
allocation_classes
async_destroy
block_cloning
bookmarks
device_rebuild
embedded_data
empty_bpobj
enabled_txg
extensible_dataset
filesystem_limits
hole_birth
large_blocks
livelist
log_spacemap
lz4_compress
obsolete_counts
project_quota
resilver_defer
spacemap_histogram
spacemap_v2
userobj_accounting
zilsaxattr
zpool_checkpoint
12 changes: 12 additions & 0 deletions man/man7/zpool-features.7
Original file line number Diff line number Diff line change
Expand Up @@ -219,17 +219,29 @@ to the end of the line is ignored.
.Bd -literal -compact -offset 4n
.No example# Nm cat Pa /usr/share/zfs/compatibility.d/grub2
# Features which are supported by GRUB2
allocation_classes
async_destroy
block_cloning
bookmarks
device_rebuild
embedded_data
empty_bpobj
enabled_txg
extensible_dataset
filesystem_limits
hole_birth
large_blocks
livelist
log_spacemap
lz4_compress
obsolete_counts
project_quota
resilver_defer
spacemap_histogram
spacemap_v2
userobj_accounting
zilsaxattr
zpool_checkpoint

.No example# Nm zpool Cm create Fl o Sy compatibility Ns = Ns Ar grub2 Ar bootpool Ar vdev
.Ed
Expand Down

0 comments on commit 583ebc6

Please sign in to comment.