Skip to content

Commit

Permalink
BRT: Don't call brt_pending_remove() on holes/embedded
Browse files Browse the repository at this point in the history
We are doing exactly the same checks around all brt_pending_add().

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
  • Loading branch information
amotin committed Nov 11, 2024
1 parent d9e78c1 commit 5ec6c8f
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions module/zfs/dbuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -2578,8 +2578,11 @@ dbuf_undirty(dmu_buf_impl_t *db, dmu_tx_t *tx)
* We are freeing a block that we cloned in the same
* transaction group.
*/
brt_pending_remove(dmu_objset_spa(db->db_objset),
&dr->dt.dl.dr_overridden_by, tx);
blkptr_t *bp = &dr->dt.dl.dr_overridden_by;
if (!BP_IS_HOLE(bp) && !BP_IS_EMBEDDED(bp)) {
brt_pending_remove(dmu_objset_spa(db->db_objset),
bp, tx);
}
}

dnode_t *dn = dr->dr_dnode;
Expand Down

0 comments on commit 5ec6c8f

Please sign in to comment.