Skip to content

Commit

Permalink
Lower minimum objects/slab threshold
Browse files Browse the repository at this point in the history
As long as we can fit a minimum of one object/slab there's no reason
to prevent the creation of the cache.  This effectively pushes the
maximum object size up to 32MB.  The splat cache tests were extended
accordingly to verify this functionality.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
  • Loading branch information
behlendorf committed Nov 5, 2014
1 parent 7f118e8 commit 917fef2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion include/sys/kmem.h
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ extern struct rw_semaphore spl_kmem_cache_sem;
#define SPL_KMEM_CACHE_DELAY 15 /* Minimum slab release age */
#define SPL_KMEM_CACHE_REAP 0 /* Default reap everything */
#define SPL_KMEM_CACHE_OBJ_PER_SLAB 16 /* Target objects per slab */
#define SPL_KMEM_CACHE_OBJ_PER_SLAB_MIN 8 /* Minimum objects per slab */
#define SPL_KMEM_CACHE_OBJ_PER_SLAB_MIN 1 /* Minimum objects per slab */
#define SPL_KMEM_CACHE_ALIGN 8 /* Default object alignment */

#define POINTER_IS_VALID(p) 0 /* Unimplemented */
Expand Down
9 changes: 9 additions & 0 deletions module/splat/splat-kmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,10 @@ splat_kmem_test6(struct file *file, void *arg)
if (rc)
return rc;

rc = splat_kmem_cache_test(file, arg, name, 16*1024*1024, 0, KMC_VMEM);
if (rc)
return rc;

/* Off slab (default + kmem + vmem) */
rc = splat_kmem_cache_test(file, arg, name, 256*1024, 0, KMC_OFFSLAB);
if (rc)
Expand All @@ -811,6 +815,11 @@ splat_kmem_test6(struct file *file, void *arg)

rc = splat_kmem_cache_test(file, arg, name, 1024*1024, 0,
KMC_VMEM | KMC_OFFSLAB);
if (rc)
return rc;

rc = splat_kmem_cache_test(file, arg, name, 16*1024*1024, 0,
KMC_VMEM | KMC_OFFSLAB);

return rc;
}
Expand Down

0 comments on commit 917fef2

Please sign in to comment.