From ca29e4f1ca70f27b147e59afc489bdfdc22a4c8d Mon Sep 17 00:00:00 2001 From: Sanjeev Bagewadi <sanjeev.bagewadi@nutanix.com> Date: Thu, 10 Aug 2017 14:45:47 +0530 Subject: [PATCH] Address review comments --- module/zfs/zio.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/module/zfs/zio.c b/module/zfs/zio.c index b1bab40a611a..5e84df11b7ba 100644 --- a/module/zfs/zio.c +++ b/module/zfs/zio.c @@ -3661,18 +3661,8 @@ zio_dva_throttle_done(zio_t *zio) ASSERT3U(zio->io_child_type, ==, ZIO_CHILD_VDEV); ASSERT(vd != NULL); ASSERT3P(vd, ==, vd->vdev_top); - /* - * If fault injection is enabled, the ZIO_FLAG_IO_RETRY could be set by - * zio_handle_device_injection() to generate the FMA events and update - * stats. Hence, ignore the flag and process such zios. - * - * A better fix would be to add another flag in the zio_t to indicate - * that the zio is failed because of a zinject rule. Considering the - * fact that we do this in debug bits, we could do with the crude check - * of zio_injection_enabled. - */ ASSERT(zio_injection_enabled || !(zio->io_flags & ZIO_FLAG_IO_RETRY)); - ASSERT(!(zio->io_flags & (ZIO_FLAG_IO_REPAIR | ZIO_FLAG_IO_RETRY))); + ASSERT(!(zio->io_flags & ZIO_FLAG_IO_REPAIR)); ASSERT(zio->io_flags & ZIO_FLAG_IO_ALLOCATING); ASSERT(!(lio->io_flags & ZIO_FLAG_IO_REWRITE)); ASSERT(!(lio->io_orig_flags & ZIO_FLAG_NODATA));