Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-key -L prompt with keyformat=raw on tty prints error thrice #11031

Closed
nabijaczleweli opened this issue Oct 8, 2020 · 0 comments
Closed
Labels
good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@nabijaczleweli
Copy link
Contributor

System information

Type Version/Name
Distribution Name Debian
Distribution Version Buster
Linux Kernel 4.19.146-1
Architecture amd64
ZFS Version 0.8.4-2~bpo10+1
SPL Version 0.8.4-2~bpo10+1

Describe the problem you're observing

zfs load-key prints the "Key load error: Cannot enter raw keys on the terminal" error three times.
I'd expect it to do this exactly once, unless it'd tried to read for three encryption roots? Which isn't the case here, and, still,

Describe how to reproduce the problem

nabijaczleweli@tarta:~$ sudo zfs create -o encryption=on -o keylocation=file:///tmp/owo -o keyformat=raw filling/store/nabijaczleweli/encrypted-zfs
nabijaczleweli@tarta:~$ sudo zfs umount filling/store/nabijaczleweli/encrypted-zfs
nabijaczleweli@tarta:~$ sudo zfs unload-key filling/store/nabijaczleweli/encrypted-zfs
nabijaczleweli@tarta:~$ sudo zfs load-key -L prompt filling/store/nabijaczleweli/encrypted-zfs
Key load error: Cannot enter raw keys on the terminal
Key load error: Cannot enter raw keys on the terminal
Key load error: Cannot enter raw keys on the terminal
@nabijaczleweli nabijaczleweli added Status: Triage Needed New issue which needs to be triaged Type: Defect Incorrect behavior (e.g. crash, hang) labels Oct 8, 2020
@behlendorf behlendorf added good first issue Indicates a good issue for first-time contributors and removed Status: Triage Needed New issue which needs to be triaged labels Oct 9, 2020
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Apr 16, 2021
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11031
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Apr 21, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 6, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 6, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 6, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 7, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 10, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 10, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 10, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 13, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
ghost pushed a commit to truenas/zfs that referenced this issue May 17, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
behlendorf pushed a commit that referenced this issue May 20, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #11911
Closes #11031
sempervictus pushed a commit to sempervictus/zfs that referenced this issue May 31, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#11911
Closes openzfs#11031
tonyhutter pushed a commit that referenced this issue Jun 23, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #11911
Closes #11031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Development

No branches or pull requests

2 participants