Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpool list -v should show SIZE for spares #12561

Closed
stuartthebruce opened this issue Sep 13, 2021 · 4 comments · Fixed by #13106
Closed

zpool list -v should show SIZE for spares #12561

stuartthebruce opened this issue Sep 13, 2021 · 4 comments · Fixed by #13106
Labels
good first issue Indicates a good issue for first-time contributors Type: Feature Feature request or new feature

Comments

@stuartthebruce
Copy link

Describe the feature would like to see added to OpenZFS

zpool list -v should display the size of spares devices rather than "-" as is currently the case for version 2.1.0

How will this feature improve OpenZFS?

This would make it easier to determine which spares are large enough to replace which devices if/when needed

Additional context
@stuartthebruce stuartthebruce added the Type: Feature Feature request or new feature label Sep 13, 2021
@behlendorf behlendorf added the good first issue Indicates a good issue for first-time contributors label Sep 17, 2021
@rHermes
Copy link
Contributor

rHermes commented Sep 30, 2021

I would like to attempt to solve this as a first issue, if that is ok?

@stuartthebruce
Copy link
Author

Go for it.

@behlendorf
Copy link
Contributor

@rHermes we'd appreciate the help.

@rHermes
Copy link
Contributor

rHermes commented Oct 4, 2021

I've been looking at this for the past few days and I've come to some realizations:

This is not a special case for spares, but rather for all non toplevel vdevs. Checking if the size is equal to 0 actually seems to be the way to determine if a vdev is infact a toplevel one or not.

This makes the change harder than expected. I've asked around on the slack channel for the reason why only top level vdevs have size information available, but I've got no answer. I'll try on the mailinglist next, but for now I'm not sure why.

There also appears to be an initiative to make this accessable to the zpool command: https://openzfs.topicbox.com/groups/developer/Tb11994f96a39413b. These per vdev props, would allow the user access to these properties. I'm going to checkout allan judes change later, to see how he does it.

It also appears that we do have the size of the physical disk in include/sys/vdev_impl.h line 408, parameter vdev_psize. I'm not sure how to get this from the kernel side and over to the userside, but I'm investigating this too.

I think that this might take a little while, atleast with my level of understand of the workings of ZFS at this point

akashb-22 added a commit to akashb-22/zfs that referenced this issue Feb 15, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
adee6ac 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
akashb-22 added a commit to akashb-22/zfs that referenced this issue Feb 15, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
8491107 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
@akashb-22 akashb-22 mentioned this issue Feb 15, 2022
Merged
13 tasks
akashb-22 added a commit to akashb-22/zfs that referenced this issue Feb 17, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
1f926c9 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
akashb-22 added a commit to akashb-22/zfs that referenced this issue Feb 18, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
04a706c 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
akashb-22 added a commit to akashb-22/zfs that referenced this issue Feb 25, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
282bd66 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
akashb-22 added a commit to akashb-22/zfs that referenced this issue Mar 4, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
f49990b 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
behlendorf pushed a commit that referenced this issue Mar 9, 2022
@akashb-22
Add physical device size to SIZE column in 'zpool list -v'
1282274 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes #12561
Closes #13106
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@akashb-22 @nicman23
Add physical device size to SIZE column in 'zpool list -v'
e09a92e 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@akashb-22 @nicman23
Add physical device size to SIZE column in 'zpool list -v'
9d1955d 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Aug 30, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
e3e9e47 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Sep 2, 2022
@akashb-22 @lundman
Add physical device size to SIZE column in 'zpool list -v'
061a1c7 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 15, 2022
@akashb-22 @tonyhutter
Add physical device size to SIZE column in 'zpool list -v'
03fa3ef 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
5e97931 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
e33dc7c 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
88404f8 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
8c22719 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
e0c6e99 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
f57673e 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
cb5fbd3 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
357dd14 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
afdd882 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
ca762c0 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@akashb-22 @andrewc12
Add physical device size to SIZE column in 'zpool list -v'
374270a 
Add physical device size/capacity only for physical devices in
'zpool list -v' instead of displaying "-" in the SIZE column.
This would make it easier to see the individual device capacity and
to determine which spares are large enough to replace which devices.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12561
Closes openzfs#13106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors Type: Feature Feature request or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add physical device size to SIZE column in 'zpool list -v' akashb-22/zfs
3 participants
@behlendorf @rHermes @stuartthebruce