srpm build failing with bash completion location complaints #15355
Labels
Type: Defect
Incorrect behavior (e.g. crash, hang)
Comments
13 tasks
13 tasks
|
Thanks for the report! I managed to reproduce it. Issue was not noticed because I did not test the patch with building rpms on a debian-derived distro (which is also what I'll try to come up with a fix. |
|
opened #15365 |
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this issue
Oct 6, 2023
The recent patch to change the bash completion install location based on the Distribution, ignored that it should still be possible to create RPMs on Debian derived systems. Additionally `make deb` itself creates RPMs and converts them via `alien`. This patch adds the bashcompletiondir variable to the rpm defines and uses this for the location, where to get the bash completion file. It still changes the location on Debian/Ubuntu systems in the final packages from /etc/bash_completion.d to /usr/share/bash-completion/completions Fixes: e69ade3 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> Closes openzfs#15355 Closes openzfs#15365
behlendorf
pushed a commit
that referenced
this issue
Oct 7, 2023
The recent patch to change the bash completion install location based on the Distribution, ignored that it should still be possible to create RPMs on Debian derived systems. Additionally `make deb` itself creates RPMs and converts them via `alien`. This patch adds the bashcompletiondir variable to the rpm defines and uses this for the location, where to get the bash completion file. It still changes the location on Debian/Ubuntu systems in the final packages from /etc/bash_completion.d to /usr/share/bash-completion/completions Fixes: e69ade3 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> Closes #15355 Closes #15365
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this issue
Dec 12, 2023
The recent patch to change the bash completion install location based on the Distribution, ignored that it should still be possible to create RPMs on Debian derived systems. Additionally `make deb` itself creates RPMs and converts them via `alien`. This patch adds the bashcompletiondir variable to the rpm defines and uses this for the location, where to get the bash completion file. It still changes the location on Debian/Ubuntu systems in the final packages from /etc/bash_completion.d to /usr/share/bash-completion/completions Fixes: e69ade3 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> Closes openzfs#15355 Closes openzfs#15365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System information
Describe the problem you're observing
Since approximately eb955f6 a
--with-config=srpmbuild fails for me like so:Describe how to reproduce the problem
A have a stabby workaround PR at #15354
Include any warning/errors/backtraces from the system logs
The text was updated successfully, but these errors were encountered: