Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale-specific time in trim status #15878

Closed
part1zano opened this issue Feb 10, 2024 · 0 comments · Fixed by #15879
Closed

Locale-specific time in trim status #15878

part1zano opened this issue Feb 10, 2024 · 0 comments · Fixed by #15879
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@part1zano
Copy link
Contributor

part1zano commented Feb 10, 2024 •
edited
Loading

System information

Type Version/Name
Distribution Name FreeBSD
Distribution Version 14.0-STABLE
Kernel Version 14.0-STABLE
Architecture amd64
OpenZFS Version zfs-2.2.2-FreeBSD_g494aaaed8

Describe the problem you're observing

In zpool status -t, trim status has its date in locale-specific format, like so:

  pool: zroot
 state: ONLINE
  scan: scrub repaired 0B in 00:09:42 with 0 errors on Fri Feb  9 14:11:58 2024
config:

        NAME          STATE     READ WRITE CKSUM
        zroot         ONLINE       0     0     0
          nda0p4.eli  ONLINE       0     0     0  (100% trimmed, completed at пятница,  9 февраля 2024 г. 14:28:37)

errors: No known data errors

As seen above, trim completion date/time is in Russian while scrub date/time version is in English.

Describe how to reproduce the problem

LANG=ru_RU.UTF-8 zpool status -t

Include any warning/errors/backtraces from the system logs
@part1zano part1zano added the Type: Defect Incorrect behavior (e.g. crash, hang) label Feb 10, 2024
@part1zano part1zano mentioned this issue Feb 10, 2024
Merged
13 tasks
behlendorf pushed a commit that referenced this issue Apr 8, 2024
@part1zano
Fix locale-specific time
f07389d 
In `zpool status -t`, scrub date/time is reported using the C locale,
while trim time is reported using the current one. This is inconsistent.
This patch fixes that.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Maxim Filimonov <che@bein.link>
Closes #15878
Closes #15879
tonyhutter pushed a commit that referenced this issue May 2, 2024
@part1zano @tonyhutter
Fix locale-specific time
86b39b4 
In `zpool status -t`, scrub date/time is reported using the C locale,
while trim time is reported using the current one. This is inconsistent.
This patch fixes that.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Maxim Filimonov <che@bein.link>
Closes #15878
Closes #15879
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Sep 4, 2024
@part1zano @lundman
Fix locale-specific time
b2f4b0b 
In `zpool status -t`, scrub date/time is reported using the C locale,
while trim time is reported using the current one. This is inconsistent.
This patch fixes that.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Maxim Filimonov <che@bein.link>
Closes openzfs#15878
Closes openzfs#15879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix locale-specific time part1zano/zfs
1 participant
@part1zano