oops in zfs_range_lock() -> avl_walk() from fsync system call

[peterhurley]

System information

Type	Version/Name
Distribution Name	Ubuntu
Distribution Version	16.04.5 LTS
Linux Kernel	4.4.0-134
Architecture	x86_64
ZFS Version	0.6.5.6-0ubuntu25
SPL Version	0.6.5.6-0ubuntu4

Describe the problem you're observing

Kernel oops in zfs_range_lock() -> avl_walk()
from fsync system call

Describe how to reproduce the problem

Unknown trigger, no repro.

Include any warning/errors/backtraces from the system logs

oops from kernel log

[1225851.981296] general protection fault: 0000 [#1] SMP 
[1225851.981539] Modules linked in: veth ufs qnx4 hfsplus hfs minix ntfs msdos jfs xfs cpuid nf_conntrack_netlink nfnetlink xfrm_user xfrm_algo br_netfilter bridge stp llc aufs pci_stub vboxpci(OE) vboxnetadp(OE) vboxnetflt(OE) vboxdrv(OE) ipmi_devintf ipt_REJECT nf_reject_ipv4 xt_multiport iptable_filter iptable_raw ipt_MASQUERADE nf_nat_masquerade_ipv4 xt_addrtype iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat ip6t_REJECT ip_tables nf_reject_ipv6 xt_tcpudp xt_comment nf_conntrack_ipv6 nf_defrag_ipv6 xt_hl ip6t_rt xt_owner xt_conntrack ip6table_filter xt_CT nf_conntrack ip6table_raw ip6_tables x_tables binfmt_misc zfs(PO) zunicode(PO) zcommon(PO) znvpair(PO) spl(O) zavl(PO) intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel input_leds joydev kvm irqbypass ipmi_ssif sb_edac
[1225851.985123]  edac_core shpchp mei_me ipmi_si mei 8250_fintek ipmi_msghandler lpc_ich acpi_power_meter acpi_pad mac_hid ib_iser rdma_cm iw_cm ib_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi autofs4 btrfs raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 multipath linear ses enclosure scsi_transport_sas ixgbe igb hid_generic crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel aes_x86_64 vxlan lrw gf128mul ip6_udp_tunnel glue_helper udp_tunnel dca ablk_helper usbhid ahci cryptd ptp hid mxm_wmi libahci i2c_algo_bit pps_core megaraid_sas mdio fjes wmi
[1225851.987938] CPU: 22 PID: 48197 Comm: vi Tainted: P        W  OE   4.4.0-133-generic #159-Ubuntu
[1225851.988309] Hardware name: Cisco Systems Inc UCSC-C240-M4SX/UCSC-C240-M4SX, BIOS C240M4.2.0.13g.0.1113162311 11/13/2016
[1225851.988777] task: ffff885e96a68e00 ti: ffff8810e7690000 task.ti: ffff8810e7690000
[1225851.989091] RIP: 0010:[<ffffffffc0419033>]  [<ffffffffc0419033>] avl_walk+0x33/0x60 [zavl]
[1225851.989476] RSP: 0018:ffff8810e7693ce0  EFLAGS: 00010202
[1225851.989720] RAX: 415d415c415b08c4 RBX: ffff880d0474f700 RCX: 0000000000000000
[1225851.990024] RDX: 0000000000000001 RSI: ffffffffc0423b02 RDI: ffffffffc0423b02
[1225851.990338] RBP: ffff8810e7693ce0 R08: 0000000000000008 R09: ffff885efec07480
[1225851.990658] R10: ffff880d0474f700 R11: ffffffffffffc000 R12: ffff881adc3fe6c0
[1225851.990977] R13: ffff88b181638800 R14: 0000000000000000 R15: 0000000000000000
[1225851.991316] FS:  00007f56d98c7800(0000) GS:ffff88befea00000(0000) knlGS:0000000000000000
[1225851.991679] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[1225851.991921] CR2: 00000000007c67ff CR3: 0000005257af4000 CR4: 0000000000360670
[1225851.992229] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[1225851.992537] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[1225851.992839] Stack:
[1225851.992928]  ffff8810e7693cf0 ffffffffc04190ea ffff8810e7693d50 ffffffffc0950da7
[1225851.993266]  ffffffffc0423b03 ffff881adc3fe7a0 ffff881adc3fe768 ffffffffc0423b03
[1225851.993625]  4e802cbe2b142854 000000003e321041 ffffc9007c52b818 0000000000000000
[1225851.993959] Call Trace:
[1225851.994070]  [<ffffffffc04190ea>] avl_nearest+0x2a/0x30 [zavl]
[1225851.994369]  [<ffffffffc0950da7>] zfs_range_lock+0x4c7/0x5e0 [zfs]
[1225851.994636]  [<ffffffffc0423b03>] ? spl_kmem_zalloc+0xa3/0x180 [spl]
[1225851.994906]  [<ffffffffc0423b03>] ? spl_kmem_zalloc+0xa3/0x180 [spl]
[1225851.995210]  [<ffffffffc095df31>] zfs_get_data+0x161/0x2f0 [zfs]
[1225851.995498]  [<ffffffffc0965f32>] zil_commit_writer+0x512/0x6d0 [zfs]
[1225851.995799]  [<ffffffffc0966673>] zil_commit.part.11+0x93/0x100 [zfs]
[1225851.996124]  [<ffffffffc09666f7>] zil_commit+0x17/0x20 [zfs]
[1225851.996403]  [<ffffffffc095c2ba>] zfs_fsync+0x7a/0xf0 [zfs]
[1225851.996651]  [<ffffffffc0972116>] zpl_fsync+0x66/0x90 [zfs]
[1225851.996887]  [<ffffffff8124b88e>] vfs_fsync_range+0x4e/0xb0
[1225851.997118]  [<ffffffff81003992>] ? syscall_trace_enter_phase1+0x122/0x140
[1225852.010386]  [<ffffffff8124b94d>] do_fsync+0x3d/0x70
[1225852.023343]  [<ffffffff8124bbf0>] SyS_fsync+0x10/0x20
[1225852.036271]  [<ffffffff8185424e>] entry_SYSCALL_64_fastpath+0x22/0xc1
[1225852.049394] Code: 47 10 b9 01 00 00 00 29 d1 48 89 e5 4c 01 c6 48 85 f6 74 40 48 63 d2 48 89 f7 48 8b 04 d6 48 85 c0 74 1a 48 63 c9 eb 03 48 89 d0 <48> 8b 14 c8 48 85 d2 75 f4 4c 29 c0 5d c3 39 d1 74 f7 48 8b 47 
[1225852.075930] RIP  [<ffffffffc0419033>] avl_walk+0x33/0x60 [zavl]
[1225852.089029]  RSP <ffff8810e7693ce0>
[1225852.125087] ---[ end trace fd6a9f0105babba4 ]---

[rincebrain]

0.6.5.6 was released 3/2016, the 0.6.5.X branch was last updated 7/2017.

If you want a bug fixed in 0.6.5.X, you will probably have better luck reporting this to Ubuntu's bugtracker.

If you would like someone around here to look at it, you're probably better off trying to reproduce it on 0.7.X or 0.8.X (though I'm not suggesting you try 0.8.X on production data unless you have backups or it's been released in non-rc form. Not because I know of any crippling bugs in it, but just as a matter of being cautious.)

(I'm not anyone important, just another person on the bug tracker who came across this bug looking for something else, lest you think this is anything but an observation.)

[stale]

This issue has been automatically marked as "stale" because it has not had any activity for a while. It will be closed in 90 days if no further activity occurs. Thank you for your contributions.