Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for persistent l2arc #925

Closed
cwedgwood opened this issue Sep 2, 2012 · 13 comments
Closed

allow for persistent l2arc #925

cwedgwood opened this issue Sep 2, 2012 · 13 comments
Labels
Type: Feature Feature request or new feature
Milestone

Comments

@cwedgwood
Copy link
Contributor

https://groups.google.com/a/zfsonlinux.org/forum/?fromgroups=#!topic/zfs-discuss/eSYYLdx73r4

References request and a suggestion on how it might be done.

@mlidbom
Copy link

mlidbom commented May 18, 2013

Seems there's an implementation of this in illumos going through final testing now:
Feature Request
Design Document
Patches
I would love to see it implemented for linux.

@behlendorf
Copy link
Contributor

Once it's merged in to Illumos in it's final form and soaks for a while I'm sure we'll pick this up.

@yshui
Copy link
Contributor

yshui commented Oct 31, 2013

Are there anyone interested in doing this? Otherwise I'll try porting and keeping track of this patch set.

@behlendorf
Copy link
Contributor

@yshui Nobody on the Linux side I know if working on this right now. If you can port the upstream patches and keep them up current that would be great. I'm sure @skiselkov would appreciate any additional testing and feedback you can provide.

edillmann pushed a commit to edillmann/zfs that referenced this issue Sep 4, 2014
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix log buffer alignment in l2arc_dev_log_commit.
v5: Fix style.
v6: l2arc vdev can go away, remove ASSERT in l2arc_spa_rebuild_start.

Close openzfs#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>
@behlendorf behlendorf modified the milestones: 0.8.0, 0.6.4 Oct 6, 2014
@grahamperrin
Copy link
Contributor

From irc://chat.freenode.net/#illumos today:

nexenta might have some kind of implementation for it, i think.

@kernelOfTruth
Copy link
Contributor

@grahamperrin thanks for the pointer !

Nexenta/illumos-nexenta@f0a9ee9 NEX-3514 Implement persistent L2ARC

Nexenta/illumos-nexenta@8872632 NEX-3514 Implement persistent L2ARC - fix build breakage in libzpool.

Nexenta/illumos-nexenta@9498bb1 NEX-3514 Implement persistent L2ARC - fix build breakage in libzpool (v2).

https://github.com/Nexenta/illumos-nexenta/commits/master?page=4

@kerberizer
Copy link

illumos 3525 is now in code review.

@cwedgwood
Copy link
Contributor Author

Updated progress at https://reviews.csiden.org/r/267/

@mailinglists35
Copy link

@behlendorf what does closing of this mean? it has been integrated/ported already? it will never be?

@behlendorf
Copy link
Contributor

The intention was to pick up this work once it was finalized and merged for illumos.

@mailinglists35
Copy link

@behlendorf could you mark it a duplicate of #3744, even if this is chronologicallty the oldest?
I had to read the other one to understand what's going on, as your reply was not really clearly explaining why it was closed.

behlendorf pushed a commit that referenced this issue Apr 10, 2020
This commit makes the L2ARC persistent across reboots. We implement
a light-weight persistent L2ARC metadata structure that allows L2ARC
contents to be recovered after a reboot. This significantly eases the
impact a reboot has on read performance on systems with large caches.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Saso Kiselkov <skiselkov@gmail.com>
Co-authored-by: Jorgen Lundman <lundman@lundman.net>
Co-authored-by: George Amanakis <gamanakis@gmail.com>
Ported-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes #925 
Closes #1823 
Closes #2672 
Closes #3744 
Closes #9582
@mailinglists35
Copy link

@behlendorf is this going to 0.8 series, or is it planned only for openzfs v2?

@behlendorf
Copy link
Contributor

It's planned for OpenZFS 2.0.

jsai20 pushed a commit to jsai20/zfs that referenced this issue Mar 30, 2021
This commit makes the L2ARC persistent across reboots. We implement
a light-weight persistent L2ARC metadata structure that allows L2ARC
contents to be recovered after a reboot. This significantly eases the
impact a reboot has on read performance on systems with large caches.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Saso Kiselkov <skiselkov@gmail.com>
Co-authored-by: Jorgen Lundman <lundman@lundman.net>
Co-authored-by: George Amanakis <gamanakis@gmail.com>
Ported-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#925 
Closes openzfs#1823 
Closes openzfs#2672 
Closes openzfs#3744 
Closes openzfs#9582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Feature request or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants