Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenZFS ports in support of pull request #9709, NFSv4 ACL support #10266

Closed
wants to merge 9 commits into from
Closed

OpenZFS ports in support of pull request #9709, NFSv4 ACL support #10266

wants to merge 9 commits into from

Conversation

pbhenson
Copy link
Contributor

Motivation and Context

These are ports of OpenZFS commits that support NFSv4 ACLs.

Description

Please see commit logs.

How Has This Been Tested?

Tested in concert with NFSv4 ACL implementation code. Compiles without it, but harder to test functionality without interface to use it :).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@pbhenson
Merge pull request #1 from zfsonlinux/master
ed53cc3 
Merge from upstream
@pbhenson
Merge branch 'master' of https://github.com/zfsonlinux/zfs
fc987c7
@pbhenson
Merge pull request #2 from openzfs/master
f80d3ca 
merge upstream
@pbhenson
OpenZFS 742 - Resurrect the ZFS "aclmode" property OpenZFS 664 - Umas…
c1411f6 
…k masking "deny" ACL entries OpenZFS 279 - Bug in the new ACL (post-PSARC/2010/029) semantics

Porting notes:
* Updated zfs_acl_chmod to take 'boolean_t isdir' as first parameter
  rather than 'zfsvfs_t *zfsvfs'
* zfs man pages changes mixed between zfs and new zfsprops man pages

Reviewed by: Aram Hvrneanu <aram@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Robert Gordon <rbg@openrbg.com>
Reviewed by: Mark.Maybee@oracle.com
Approved by: Garrett D'Amore <garrett@nexenta.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/742
OpenZFS-issue: https://www.illumos.org/issues/664
OpenZFS-issue: https://www.illumos.org/issues/279
OpenZFS-commit: openzfs/openzfs@a3c49ce110
@pbhenson
OpenZFS 3254 - add support in zfs for aclmode=restricted
c03ec5e 
Authored-by: Paul B. Henson <henson@acm.org>
Reviewed by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/3254
OpenZFS-commit: openzfs/openzfs@71dbfc287c
@pbhenson
OpenZFS 6764 - zfs issues with inheritance flags during chmod(2)
99a9df5 
with aclmode=passthrough

Authored by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6764
OpenZFS-commit: openzfs/openzfs@de0f1ddb59
@pbhenson
OpenZFS 8984 - fix for 6764 breaks ACL inheritance
b2eb5af 
Authored by: Dominik Hassler <hadfl@omniosce.org>
Reviewed by: Sam Zaydel <szaydel@racktopsystems.com>
Reviewed by: Paul B. Henson <henson@acm.org>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Approved by: Matthew Ahrens <mahrens@delphix.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/8984
OpenZFS-commit: openzfs/openzfs@e9bacc6d1a
@pbhenson
OpenZFS 6762 - POSIX write should imply DELETE_CHILD on directories
f6ab211 
- and some additional considerations

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6762
OpenZFS-commit: openzfs/openzfs@1eb4e906ec
@pbhenson
OpenZFS 6765 - zfs_zaccess_delete() comments do not accurately
32e51f9 
reflect delete permissions for ACLs

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

Porting Notes:
* Only comments are updated

OpenZFS-issue: https://www.illumos.org/issues/6765
OpenZFS-commit: openzfs/openzfs@da412744bc
@pbhenson pbhenson mentioned this pull request Apr 29, 2020
Closed
7 tasks
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 29, 2020
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 30, 2020
behlendorf pushed a commit that referenced this pull request Apr 30, 2020
@pbhenson @behlendorf
OpenZFS 3254 - add support in zfs for aclmode=restricted
7bf3e1f 
Authored-by: Paul B. Henson <henson@acm.org>
Reviewed by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/3254
OpenZFS-commit: openzfs/openzfs@71dbfc287c
Closes #10266
behlendorf pushed a commit that referenced this pull request Apr 30, 2020
@pbhenson @behlendorf
OpenZFS 6764 - zfs issues with inheritance flags during chmod(2)
5a2f527 
with aclmode=passthrough

Authored by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6764
OpenZFS-commit: openzfs/openzfs@de0f1ddb59
Closes #10266
behlendorf pushed a commit that referenced this pull request Apr 30, 2020
@pbhenson @behlendorf
OpenZFS 8984 - fix for 6764 breaks ACL inheritance
99495ba 
Authored by: Dominik Hassler <hadfl@omniosce.org>
Reviewed by: Sam Zaydel <szaydel@racktopsystems.com>
Reviewed by: Paul B. Henson <henson@acm.org>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Matthew Ahrens <mahrens@delphix.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/8984
OpenZFS-commit: openzfs/openzfs@e9bacc6d1a
Closes #10266
behlendorf pushed a commit that referenced this pull request Apr 30, 2020
@pbhenson @behlendorf
OpenZFS 6762 - POSIX write should imply DELETE_CHILD on directories
235a856 
- and some additional considerations

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6762
OpenZFS-commit: openzfs/openzfs@1eb4e906ec
Closes #10266
behlendorf pushed a commit that referenced this pull request Apr 30, 2020
@pbhenson @behlendorf
OpenZFS 6765 - zfs_zaccess_delete() comments do not accurately
0aeb0be 
reflect delete permissions for ACLs

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

Porting Notes:
* Only comments are updated

OpenZFS-issue: https://www.illumos.org/issues/6765
OpenZFS-commit: openzfs/openzfs@da412744bc
Closes #10266
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@pbhenson @as-com
OpenZFS 742 - Resurrect the ZFS "aclmode" property OpenZFS 664 - Umas…
b917b56 
…k masking "deny" ACL entries OpenZFS 279 - Bug in the new ACL (post-PSARC/2010/029) semantics

Porting notes:
* Updated zfs_acl_chmod to take 'boolean_t isdir' as first parameter
  rather than 'zfsvfs_t *zfsvfs'
* zfs man pages changes mixed between zfs and new zfsprops man pages

Reviewed by: Aram Hvrneanu <aram@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Robert Gordon <rbg@openrbg.com>
Reviewed by: Mark.Maybee@oracle.com
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@nexenta.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/742
OpenZFS-issue: https://www.illumos.org/issues/664
OpenZFS-issue: https://www.illumos.org/issues/279
OpenZFS-commit: openzfs/openzfs@a3c49ce110
Closes openzfs#10266

(cherry picked from commit a1af567)
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@pbhenson @as-com
OpenZFS 3254 - add support in zfs for aclmode=restricted
ee6378d 
Authored-by: Paul B. Henson <henson@acm.org>
Reviewed by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/3254
OpenZFS-commit: openzfs/openzfs@71dbfc287c
Closes openzfs#10266

(cherry picked from commit 7bf3e1f)
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@pbhenson @as-com
OpenZFS 6764 - zfs issues with inheritance flags during chmod(2)
7682af3 
with aclmode=passthrough

Authored by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6764
OpenZFS-commit: openzfs/openzfs@de0f1ddb59
Closes openzfs#10266

(cherry picked from commit 5a2f527)
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@pbhenson @as-com
OpenZFS 8984 - fix for 6764 breaks ACL inheritance
0b472e4 
Authored by: Dominik Hassler <hadfl@omniosce.org>
Reviewed by: Sam Zaydel <szaydel@racktopsystems.com>
Reviewed by: Paul B. Henson <henson@acm.org>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Matthew Ahrens <mahrens@delphix.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/8984
OpenZFS-commit: openzfs/openzfs@e9bacc6d1a
Closes openzfs#10266

(cherry picked from commit 99495ba)
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@pbhenson @as-com
OpenZFS 6762 - POSIX write should imply DELETE_CHILD on directories
3c25183 
- and some additional considerations

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6762
OpenZFS-commit: openzfs/openzfs@1eb4e906ec
Closes openzfs#10266

(cherry picked from commit 235a856)
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
@pbhenson @as-com
OpenZFS 6765 - zfs_zaccess_delete() comments do not accurately
c9f6d82 
reflect delete permissions for ACLs

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

Porting Notes:
* Only comments are updated

OpenZFS-issue: https://www.illumos.org/issues/6765
OpenZFS-commit: openzfs/openzfs@da412744bc
Closes openzfs#10266

(cherry picked from commit 0aeb0be)
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pbhenson @jsai20
OpenZFS 742 - Resurrect the ZFS "aclmode" property OpenZFS 664 - Umas…
8b34b42 
…k masking "deny" ACL entries OpenZFS 279 - Bug in the new ACL (post-PSARC/2010/029) semantics

Porting notes:
* Updated zfs_acl_chmod to take 'boolean_t isdir' as first parameter
  rather than 'zfsvfs_t *zfsvfs'
* zfs man pages changes mixed between zfs and new zfsprops man pages

Reviewed by: Aram Hvrneanu <aram@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Robert Gordon <rbg@openrbg.com>
Reviewed by: Mark.Maybee@oracle.com
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@nexenta.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/742
OpenZFS-issue: https://www.illumos.org/issues/664
OpenZFS-issue: https://www.illumos.org/issues/279
OpenZFS-commit: openzfs/openzfs@a3c49ce110
Closes openzfs#10266
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pbhenson @jsai20
OpenZFS 3254 - add support in zfs for aclmode=restricted
cdcf53f 
Authored-by: Paul B. Henson <henson@acm.org>
Reviewed by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/3254
OpenZFS-commit: openzfs/openzfs@71dbfc287c
Closes openzfs#10266
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pbhenson @jsai20
OpenZFS 6764 - zfs issues with inheritance flags during chmod(2)
0cb2b29 
with aclmode=passthrough

Authored by: Albert Lee <trisk@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6764
OpenZFS-commit: openzfs/openzfs@de0f1ddb59
Closes openzfs#10266
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pbhenson @jsai20
OpenZFS 8984 - fix for 6764 breaks ACL inheritance
72c982a 
Authored by: Dominik Hassler <hadfl@omniosce.org>
Reviewed by: Sam Zaydel <szaydel@racktopsystems.com>
Reviewed by: Paul B. Henson <henson@acm.org>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Matthew Ahrens <mahrens@delphix.com>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/8984
OpenZFS-commit: openzfs/openzfs@e9bacc6d1a
Closes openzfs#10266
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pbhenson @jsai20
OpenZFS 6762 - POSIX write should imply DELETE_CHILD on directories
8a637ac 
- and some additional considerations

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

OpenZFS-issue: https://www.illumos.org/issues/6762
OpenZFS-commit: openzfs/openzfs@1eb4e906ec
Closes openzfs#10266
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@pbhenson @jsai20
OpenZFS 6765 - zfs_zaccess_delete() comments do not accurately
8e96017 
reflect delete permissions for ACLs

Authored by: Kevin Crowe <kevin.crowe@nexenta.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Richard Lowe <richlowe@richlowe.net>
Ported-by: Paul B. Henson <henson@acm.org>

Porting Notes:
* Only comments are updated

OpenZFS-issue: https://www.illumos.org/issues/6765
OpenZFS-commit: openzfs/openzfs@da412744bc
Closes openzfs#10266
@mjyu51
Copy link

mjyu51 commented Apr 4, 2021

Will this NFSv4 ACL be merged into the latest 2.0.x?

@ghost
Copy link

ghost commented Apr 4, 2021 •
edited by ghost
Loading

Will this NFSv4 ACL be merged into the latest 2.0.x?

This PR does not add support for NFSv4 ACLs on Linux. These commits in this PR are already in the zfs-2.0-release branch. The work on NFSv4 ACL support in OpenZFS on Linux is still in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbhenson @mjyu51 @behlendorf