Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up uio headers #11622

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Cleaning up uio headers #11622

merged 1 commit into from
Feb 21, 2021

Conversation

bwatkinson
Copy link
Contributor

Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Signed-off-by: Brian Atkinson batkinson@lanl.gov

Making uio_impl.h the common header for FreeBSD and Linux. This way we save on duplicating
code for the zfs_uio_t between both OS's.

Motivation and Context

Just general code clean up.

Description

Have moved all the common static zfs_uio_t functions into uio_impl.h. This also allows just
zfs_context.h or zfs_impl.h to be used in common code.

How Has This Been Tested?

Ran zloop.sh.

CentOS 8: kernel 4.18.0-193.el8.x86_64
FreeBSD 12.2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@bwatkinson bwatkinson requested review from a user and behlendorf February 20, 2021 03:06
behlendorf
behlendorf reviewed Feb 20, 2021
View reviewed changes
include/sys/uio_impl.h Outdated Show resolved Hide resolved
include/sys/uio_impl.h Outdated Show resolved Hide resolved
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Feb 20, 2021
@bwatkinson
Cleaning up uio headers
b859abb 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 21, 2021
@behlendorf behlendorf merged commit c0801bf into openzfs:master Feb 21, 2021
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@bwatkinson @jsai20
Cleaning up uio headers
895ff8e 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#11622
bwatkinson added a commit to bwatkinson/zfs that referenced this pull request May 11, 2021
@bwatkinson
Cleaning up uio headers
c27b84a 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#11622
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@bwatkinson
Cleaning up uio headers
8644312 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#11622
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 6, 2021
@bwatkinson @tonyhutter
Cleaning up uio headers
08eab48 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#11622
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@bwatkinson @tonyhutter
Cleaning up uio headers
9dd0d52 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#11622
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@bwatkinson @tonyhutter
Cleaning up uio headers
d10c35b 
Making uio_impl.h the common header interface between Linux and FreeBSD
so both OS's can share a common header file. This also helps reduce code
duplication for zfs_uio_t for each OS.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#11622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwatkinson @behlendorf