Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap bare EINVAL returns with SET_ERROR #11636

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Wrap bare EINVAL returns with SET_ERROR #11636

merged 1 commit into from
Feb 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2021

Motivation and Context

SET_ERROR() is helpful for tracing errors in ZFS. It should be used when returning a new error.

Description

Wrap a couple of bare EINVAL returns in zfs_ioctl.c with SET_ERROR.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Wrap bare EINVAL returns with SET_ERROR
9f06f4c 
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Feb 22, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 24, 2021
@behlendorf behlendorf merged commit 5156862 into openzfs:master Feb 24, 2021
@ghost ghost deleted the ioctl-einval branch February 24, 2021 20:59
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
Wrap bare EINVAL returns with SET_ERROR
c402075 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11636
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
Wrap bare EINVAL returns with SET_ERROR
3b4de36 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11636
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
Wrap bare EINVAL returns with SET_ERROR
c6a70e1 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11636
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
Wrap bare EINVAL returns with SET_ERROR
ae7a428 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11636
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Wrap bare EINVAL returns with SET_ERROR
400d95f 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11636
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
Wrap bare EINVAL returns with SET_ERROR
818bc70 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf