Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Add tests for DOS mode flags on FreeBSD #11734

Merged
merged 1 commit into from
Mar 16, 2021
Merged

ZTS: Add tests for DOS mode flags on FreeBSD #11734

merged 1 commit into from
Mar 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2021 •
edited by ghost
Loading

Motivation and Context

We recently fixed a regression in the behavior of the DOS mode READONLY flag on FreeBSD in 4b2e208.
Here is the corresponding test case to catch the issue, along with tests for other important DOS mode flags.

Description

Start a new section of acl tests for acltype=off.
For now I'm adding only the DOS mode flag tests for FreeBSD.
Over time this will be a place to add basic POSIX mode tests, as well.

How Has This Been Tested?

ZTS on FreeBSD

Types of changes

I guess tests are a feature lack of tests is a bug :)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Mar 12, 2021
@ghost
Copy link
Author

ghost commented Mar 12, 2021

This is based on the fixed user_run from #11185. When that's merged I'll be able to rebase so only one commit is added in this PR.

@behlendorf
Copy link
Contributor

@freqlabs you should be able to rebase this now.

ZTS: Add tests for DOS mode attributes
0184c72 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost force-pushed the zts-acl-off branch from de61384 to 0184c72 Compare March 13, 2021 05:50
@ghost
Copy link
Author

ghost commented Mar 15, 2021

  • Rebased

behlendorf
behlendorf approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 15, 2021
@behlendorf behlendorf merged commit 5638803 into openzfs:master Mar 16, 2021
@ghost ghost deleted the zts-acl-off branch March 17, 2021 13:41
ghost pushed a commit to truenas/zfs that referenced this pull request Mar 23, 2021
ZTS: Add tests for DOS mode attributes
b6d905c 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
ZTS: Add tests for DOS mode attributes
999e2cb 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request Apr 5, 2021
ZTS: Add tests for DOS mode attributes
e1ed850 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@adamdmoss
ZTS: Add tests for DOS mode attributes
7020e0c 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 3, 2021
ZTS: Add tests for DOS mode attributes
c2810d2 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Add tests for DOS mode attributes
f635a48 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
ZTS: Add tests for DOS mode attributes
44e287d 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Add tests for DOS mode attributes
0908210 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Add tests for DOS mode attributes
8efc467 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Add tests for DOS mode attributes
73f802f 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
ZTS: Add tests for DOS mode attributes
239c466 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
ZTS: Add tests for DOS mode attributes
d8c281a 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11734
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
ZTS: Add tests for DOS mode attributes
73edc36 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11734
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
ZTS: Add tests for DOS mode attributes
2439e95 
Create a new section of tests to run with acltype=off.

For now the only test we have is for the DOS mode READONLY attribute on
FreeBSD.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf