Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Tests using zhack may fail on FreeBSD #11855

Merged
merged 1 commit into from
Apr 8, 2021
Merged

ZTS: Tests using zhack may fail on FreeBSD #11855

merged 1 commit into from
Apr 8, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2021

Motivation and Context

As described in #11854, zhack is occasionally segfaulting on FreeBSD. Debugging this is proving to be tricky.

Description

Add entries for the tests that use zhack in zts-report to accept that they may occasionally fail on FreeBSD.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

ZTS: Tests using zhack may fail on FreeBSD
37f6dfd 
Issue openzfs#11854

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Apr 7, 2021
@ghost ghost requested a review from behlendorf April 7, 2021 15:02
@behlendorf
Copy link
Contributor

For what it's worth, I checked the CI logs and verified we are in fact only observing this on FreeBSD for some reason. Why that's the case is a mystery.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 7, 2021
@behlendorf behlendorf merged commit 3834015 into openzfs:master Apr 8, 2021
@ghost ghost deleted the zts-flaky-zhack branch April 8, 2021 21:00
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 10, 2021
@mcmilk
ZTS: Tests using zhack may fail on FreeBSD
f7ce00b 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@adamdmoss
ZTS: Tests using zhack may fail on FreeBSD
9221923 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 10, 2021
@mcmilk
ZTS: Tests using zhack may fail on FreeBSD
89c42bb 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
@behlendorf
ZTS: Tests using zhack may fail on FreeBSD
72a9750 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Tests using zhack may fail on FreeBSD
03ce679 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Tests using zhack may fail on FreeBSD
0cee9b1 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
ZTS: Tests using zhack may fail on FreeBSD
5741a66 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
ZTS: Tests using zhack may fail on FreeBSD
c80217a 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Tests using zhack may fail on FreeBSD
6004d3c 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Tests using zhack may fail on FreeBSD
96da574 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
ZTS: Tests using zhack may fail on FreeBSD
b37f512 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
ZTS: Tests using zhack may fail on FreeBSD
e6b394f 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
ZTS: Tests using zhack may fail on FreeBSD
dea9aed 
As described in #11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue #11854
Closes #11855
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
ZTS: Tests using zhack may fail on FreeBSD
8922c35 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
ZTS: Tests using zhack may fail on FreeBSD
57490d5 
As described in #11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue #11854
Closes #11855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @jwk404