Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libspl: staticify buf and pagesize, rename aok to libspl_assert_ok #12050

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented May 15, 2021

Motivation and Context

Exporting names this short can easily cause nasty collisions with user code. aok, being the "abort or raze my disk" tunable, is particularly fun.

Description

See above.

How Has This Been Tested?

It builds, I guess?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv) – though apparently the only use of aok is for zdb, so it don't matter too much
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply, hopefully
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli nabijaczleweli force-pushed the what-i-do-with-a-phone-in-the-privacy-of-my-own-home branch from d3ca115 to 0860018 Compare May 15, 2021 21:50
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli force-pushed the what-i-do-with-a-phone-in-the-privacy-of-my-own-home branch from 0860018 to 560efb2 Compare May 15, 2021 22:06
@jwk404 jwk404 added the Status: Code Review Needed Ready for review and testing label May 20, 2021
@nabijaczleweli nabijaczleweli mentioned this pull request May 25, 2021
13 tasks
@jwk404 jwk404 merged commit 94f942c into openzfs:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants