Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite mount.zfs(8) and touch up zfsprops(8) WRT nbmand and temp options #12111

Closed
wants to merge 3 commits into from
Closed

Rewrite mount.zfs(8) and touch up zfsprops(8) WRT nbmand and temp options #12111

wants to merge 3 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

Motivation and Context

nbmand was a mystery to me; no longer.

Description

See individual commit messages.

How Has This Been Tested?

Looked at it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@nabijaczleweli
zfsprops.8: remove nbmand-not-used-on-Linux and pointer to mount(8)
6023a20 
Linux man-pages' mount(8) points at fcntl(2), as does mount(2),
and support for it is little-used, deprecated, and configurable
since 4.5.

As far as I can tell, FreeBSD doesn't support nbmand at all ‒
mandatory locks are mostly dead

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
mount.zfs.8: modernise
6b06fe3 
No changes to the text itself

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli changed the title zfsprops.8: remove nbmand-not-used-on-Linux and pointer to mount(8) Rewrite mount.zfs(8) and touch up zfsprops(8) WRT nbmand and temp options May 24, 2021
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 25, 2021
behlendorf
behlendorf approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this documentation. The change itself looks good to me, just a suggested change to try and make the mount.zfs(8) description as clear as possible.

man/man8/mount.zfs.8 Outdated Show resolved Hide resolved
@nabijaczleweli
mount.zfs.8: match to reality; zfsprops.8: add missing temporary options
5b443df 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli mentioned this pull request May 26, 2021
Closed
13 tasks
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 27, 2021
behlendorf pushed a commit that referenced this pull request May 27, 2021
@nabijaczleweli @behlendorf
mount.zfs.8: modernise
eae3598 
No changes to the text itself

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12111
behlendorf pushed a commit that referenced this pull request May 27, 2021
@nabijaczleweli @behlendorf
mount.zfs.8: match to reality; zfsprops.8: add missing temporary options
20bd864 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12111
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 28, 2021
@nabijaczleweli @behlendorf
zfsprops.8: remove nbmand-not-used-on-Linux and pointer to mount(8)
f322206 
Linux man-pages' mount(8) points at fcntl(2), as does mount(2),
and support for it is little-used, deprecated, and configurable
since 4.5.

As far as I can tell, FreeBSD doesn't support nbmand at all ‒
mandatory locks are mostly dead

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12111
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 28, 2021
@nabijaczleweli @behlendorf
mount.zfs.8: modernise
bc7792c 
No changes to the text itself

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12111
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 28, 2021
@nabijaczleweli @behlendorf
mount.zfs.8: match to reality; zfsprops.8: add missing temporary options
c5f268f 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12111
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@nabijaczleweli
zfsprops.8: remove nbmand-not-used-on-Linux and pointer to mount(8)
fb703b0 
Linux man-pages' mount(8) points at fcntl(2), as does mount(2),
and support for it is little-used, deprecated, and configurable
since 4.5.

As far as I can tell, FreeBSD doesn't support nbmand at all ‒
mandatory locks are mostly dead

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12111
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@nabijaczleweli
mount.zfs.8: modernise
7fa3e10 
No changes to the text itself

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12111
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@nabijaczleweli
mount.zfs.8: match to reality; zfsprops.8: add missing temporary options
ab6cdbe 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @behlendorf @tonynguien