Minor fix to configure on s390x #12126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure on s390x has a key check fail with an error about a variable being used uninitialized. So let's initialize it. Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
behlendorf
approved these changes
May 26, 2021
|
@ColinIanKing I wanted to make sure you saw this fix since I know you've sorted out some s390x build issues in the past. Would you mind taking a couple minutes to review this. |
|
I've currently not got access to H/W to test this and I'm loathed to build this in an emulated s390x QEMU instance as this will take me most of a day to complete. From what I see this change looks good to me. |
|
Not a problem, thanks for taking a look. |
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
May 28, 2021
configure on s390x has a key check fail with an error about a variable being used uninitialized. So let's initialize it. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12126
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
configure on s390x has a key check fail with an error about a variable being used uninitialized. So let's initialize it. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
configure on s390x on my testbed has a key check fail with a warning promoted to error about
a variable being used uninitialized. Specifically,
/usr/src/linux-headers-4.19.0-16-common/arch/s390/include/asm/atomic_ops.h:101:27: error: 'zfs_bdi_seq' is used uninitialized in this function [-Werror=uninitialized]Description
Just inserts an
atomic_long_set(X, 0);to silence its complaints.How Has This Been Tested?
configure finished on Debian buster x86_64 and Debian buster s390x after this, while it failed on the latter before. (s390x also functions normally, albeit with a number of ZTS failures, after.)
Types of changes
Checklist:
Signed-off-by.