Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_key_material_file fail more verbosely #12410

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Make get_key_material_file fail more verbosely #12410

merged 1 commit into from
Aug 5, 2021

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

Someone reported getting "Failed to open key material file", and we would have liked to know why, exactly.

Description

sed -e s#"))#: %s"), strerror(ret))#

How Has This Been Tested?

It built, passed checkstyle on my machine, printed No such file or directory when I gave keylocation=file:///does/not/exist.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rincebrain
Make get_key_material_file fail more verbosely
24cbdd4 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 21, 2021
@tonynguien tonynguien added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 5, 2021
@tonynguien tonynguien merged commit f3678d7 into openzfs:master Aug 5, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@rincebrain @behlendorf
Make get_key_material_file fail more verbosely
6c66bf1 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12410
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@rincebrain @behlendorf
Make get_key_material_file fail more verbosely
b81e8fb 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12410
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@rincebrain
Make get_key_material_file fail more verbosely
2a68952 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12410
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@rincebrain @behlendorf
Make get_key_material_file fail more verbosely
b7aa09c 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12410
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@rincebrain @behlendorf
Make get_key_material_file fail more verbosely
1b34ef2 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes #12410
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@rincebrain @tonyhutter
Make get_key_material_file fail more verbosely
23184b1 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12410
rincebrain added a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@rincebrain
Make get_key_material_file fail more verbosely
edb972e 
It turns out, there are a lot of possible reasons for fopen to fail.
Let's share which reason we failed for today.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonynguien tonynguien tonynguien approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rincebrain @behlendorf @tonynguien