Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix zpool_reopen_[1-5] on Fedora 35 #12871

Merged
merged 1 commit into from
Dec 17, 2021
Merged

ZTS: Fix zpool_reopen_[1-5] on Fedora 35 #12871

merged 1 commit into from
Dec 17, 2021

Conversation

tonyhutter
Copy link
Contributor

Motivation and Context

Fix zpool_reopen_[1-5] tests on Fedora 35

Description

The zpool_reopen_[1-5] tests are failing Fedora 35:

zpool_reopen_001_pos.ksh[64]: log_must[67]: log_pos[270]: wait_for_resilver_end[98]: wait_for_action: line 71: func: is read only

Renaming 'func' -> 'funct' fixes the issue.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter
ZTS: Fix zpool_reopen_[1-5] on Fedora 35
31192a4 
The zpool_reopen_[1-5] tests are failing Fedora 35:

zpool_reopen_001_pos.ksh[64]: log_must[67]: log_pos[270]:
    wait_for_resilver_end[98]: wait_for_action: line 71: func: is read only

Renaming 'func' -> 'funct' fixes the issue.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@tonyhutter tonyhutter added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Dec 16, 2021
gmelikov
gmelikov approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: error: commit message body contains line over 72 characters

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 17, 2021
@behlendorf behlendorf merged commit 9aa0915 into openzfs:master Dec 17, 2021
@behlendorf
Copy link
Contributor

I addressed the 72 character warning in the commit message when merging.

tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@tonyhutter
ZTS: Fix zpool_reopen_[1-5] on Fedora 35
29e05d5 
The zpool_reopen_[1-5] tests are failing Fedora 35 with:

zpool_reopen_001_pos.ksh[64]: log_must[67]: log_pos[270]:
wait_for_resilver_end[98]: wait_for_action: line 71: func: is read only

Renaming 'func' -> 'funct' fixes the issue.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12871
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@tonyhutter @nicman23
ZTS: Fix zpool_reopen_[1-5] on Fedora 35
17f672e 
The zpool_reopen_[1-5] tests are failing Fedora 35 with:

zpool_reopen_001_pos.ksh[64]: log_must[67]: log_pos[270]:
wait_for_resilver_end[98]: wait_for_action: line 71: func: is read only

Renaming 'func' -> 'funct' fixes the issue.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12871
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@tonyhutter @nicman23
ZTS: Fix zpool_reopen_[1-5] on Fedora 35
a0f621b 
The zpool_reopen_[1-5] tests are failing Fedora 35 with:

zpool_reopen_001_pos.ksh[64]: log_must[67]: log_pos[270]:
wait_for_resilver_end[98]: wait_for_action: line 71: func: is read only

Renaming 'func' -> 'funct' fixes the issue.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyhutter @behlendorf @gmelikov