Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report dnodes with faulty bonuslen #13014

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Report dnodes with faulty bonuslen #13014

merged 1 commit into from
Feb 3, 2022

Conversation

gamanakis
Copy link
Contributor

@gamanakis gamanakis commented Jan 25, 2022 •
edited
Loading

Motivation and Context

Closes #12720.

In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This is because
currently only the raw receive path checks for discrepancies between the
bonus length and the spill pointer flag.

Description

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
and dsl_scan_recurse() to report errors during a scrub. Also added a
test to verify spill blocks are sent correctly in a raw send.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rincebrain
Copy link
Contributor

An error on scrub feels kind of unfortunate, since it's not like there's a way to recover short of rewriting your data...I can't think of a better alternative though.

@gamanakis gamanakis force-pushed the is12720_squash branch 6 times, most recently from b8558c6 to 0960c34 Compare January 25, 2022 21:20
behlendorf
behlendorf reviewed Jan 25, 2022
View reviewed changes
module/zfs/dnode_sync.c Outdated Show resolved Hide resolved
module/zfs/dsl_scan.c Show resolved Hide resolved
@gamanakis
Copy link
Contributor Author

2545ee4: Suggestions from @behlendorf, teach zstream dump to report a warning.

@gamanakis
Copy link
Contributor Author

ce90548: fix typos in commit message

@gamanakis gamanakis marked this pull request as ready for review January 26, 2022 19:11
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 26, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 2, 2022
@gamanakis
Copy link
Contributor Author

gamanakis commented Feb 3, 2022 •
edited
Loading

b2dfbd0 and 59724dc: rebased to master

@gamanakis
Report dnodes with faulty bonuslen
59724dc 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Signed-off-by: George Amanakis <gamanakis@gmail.com>
@behlendorf behlendorf merged commit f3b08df into openzfs:master Feb 3, 2022
gamanakis added a commit to gamanakis/zfs that referenced this pull request Feb 8, 2022
@gamanakis
Report dnodes with faulty bonuslen
c4adf03 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@gamanakis @tonyhutter
Report dnodes with faulty bonuslen
ef7db89 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 14, 2022
@gamanakis @tonyhutter
Report dnodes with faulty bonuslen
c3bf3e4 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@gamanakis @tonyhutter
Report dnodes with faulty bonuslen
c7d0653 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@gamanakis @tonyhutter
Report dnodes with faulty bonuslen
72a82f3 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
@gamanakis gamanakis mentioned this pull request Feb 26, 2022
Merged
13 tasks
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@gamanakis @nicman23
Report dnodes with faulty bonuslen
695bf8d 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@gamanakis @nicman23
Report dnodes with faulty bonuslen
5654fef 
In files created/modified before 4254acb there may be a corruption of
xattrs which is not reported during scrub and normal send/receive. It
manifests only as an error when raw sending/receiving. This happens
because currently only the raw receive path checks for discrepancies
between the dnode bonus length and the spill pointer flag.

In case we encounter a dnode whose bonus length is greater than the
predicted one, we should report an error. Modify in this regard
dnode_sync() with an assertion at the end, dump_dnode() to error out,
dsl_scan_recurse() to report errors during a scrub, and zstream to
report a warning when dumping. Also added a test to verify spill blocks
are sent correctly in a raw send.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#12720 
Closes openzfs#13014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to receive encrypted raw send
3 participants
@gamanakis @rincebrain @behlendorf