Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Update enospc_002_pos test case #13060

Merged
merged 1 commit into from
Feb 4, 2022
Merged

ZTS: Update enospc_002_pos test case #13060

merged 1 commit into from
Feb 4, 2022

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

The enospc_002_pos test may incorrectly fail resulting in CI failures.

http://build.zfsonlinux.org/builders/CentOS%207%20x86_64%20%28TEST%29/builds/18786

Description

The on-disk cost of creating a bookmark is sufficently low that it
is difficult to make it reliably fail even when the pool is "full".
In order to avoid this test incorrectly failing because the bookmark
was created the check has been removed.

How Has This Been Tested?

Locally ran the test on a system where it would reliably fail.
After removing this check it passes reliably. Submitted to the
CI to confirm it resolves the false positives.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Feb 3, 2022
@behlendorf
ZTS: Update enospc_002_pos test case
097d003 
The on-disk cost of creating a snapshot or bookmark is sufficently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf
Copy link
Contributor Author

It appears this is also possible for snapshots, which isn't too surprising. I've removed the snapshot check as well.

@behlendorf behlendorf merged commit 100b895 into openzfs:master Feb 4, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 4, 2022
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@behlendorf @tonyhutter
ZTS: Update enospc_002_pos test case
85277c6 
The on-disk cost of creating a snapshot or bookmark is sufficiently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13060
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 14, 2022
@behlendorf @tonyhutter
ZTS: Update enospc_002_pos test case
b428c45 
The on-disk cost of creating a snapshot or bookmark is sufficiently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13060
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@behlendorf @tonyhutter
ZTS: Update enospc_002_pos test case
de8751e 
The on-disk cost of creating a snapshot or bookmark is sufficiently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13060
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@behlendorf @tonyhutter
ZTS: Update enospc_002_pos test case
cd0e238 
The on-disk cost of creating a snapshot or bookmark is sufficiently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13060
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
ZTS: Update enospc_002_pos test case
30bb140 
The on-disk cost of creating a snapshot or bookmark is sufficiently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13060
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
ZTS: Update enospc_002_pos test case
31b4880 
The on-disk cost of creating a snapshot or bookmark is sufficiently low
that it is difficult to make it reliably fail even when the pool is
"full".  In order to avoid false positives remove these two checks from
the test case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@jwk404 jwk404 jwk404 approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @jwk404 @gmelikov