Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ZTS test for O_APPEND #13424

Merged
merged 1 commit into from
May 11, 2022
Merged

Adding ZTS test for O_APPEND #13424

merged 1 commit into from
May 11, 2022

Conversation

bwatkinson
Copy link
Contributor

@bwatkinson bwatkinson commented May 5, 2022 •
edited
Loading

Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Signed-off-by: Brian Atkinson batkinson@lanl.gov

Just adding a ZTS test for O_APPEND.

Motivation and Context

Recently 63b18e4 was merged to address an issue accounting for updating the file offset
when the file is opened with O_APPEND. This PR just adds a quick test so in the future other
distros / kernel versions can also be checked to make sure the correct behavior is observed with
O_APPEND.

Description

Simply just added a ZTS test. Also added a new C program in the cmd/file directory to open
a file with O_APPEND and O_DIRECT to verify correctness. The addition of also doing O_DIRECT
is in preparation for #10018 eventually being merged.

How Has This Been Tested?

Tested new ZTS test tag append on both Linux and FreeBSD.

CentOS 8.2.2004 - Kernel 4.18.0-193.el8.x86_64
FreeBSD 12.2 STABLE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@bwatkinson bwatkinson requested a review from behlendorf May 5, 2022 23:40
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 6, 2022
behlendorf
behlendorf reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you please rebase it. I just merged since significant restructuring to the build system's Makefiles. As part of that work a few things moved around, and are now wired up a little bit differently.

Let's also move the threadsappend/threadsappend_001_pos.ksh test case in to this new append directory to keep the tests together. You'll also need to update the zts-report.py.in script since this test case is one of our exceptions.

@bwatkinson
Copy link
Contributor Author

Looks good, but can you please rebase it. I just merged since significant restructuring to the build system's Makefiles. As part of that work a few things moved around, and are now wired up a little bit differently.

Let's also move the threadsappend/threadsappend_001_pos.ksh test case in to this new append directory to keep the tests together. You'll also need to update the zts-report.py.in script since this test case is one of our exceptions.

I have taken care of updating the build system and moving the threadsappend test case into the append directory.

@bwatkinson
Adding ZTS test for O_APPEND
f97e205 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 11, 2022
@behlendorf behlendorf merged commit f567d67 into openzfs:master May 11, 2022
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@bwatkinson @nicman23
Adding ZTS test for O_APPEND
bfbcccf 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@bwatkinson @nicman23
Adding ZTS test for O_APPEND
7317dee 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 6, 2022
@bwatkinson @lundman
Adding ZTS test for O_APPEND
46525d4 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@bwatkinson @beren12
Adding ZTS test for O_APPEND
9b63e27 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
3ce0fcc 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
4353281 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
e207130 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
4091db9 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
dbd5a2a 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
f70a739 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
0c5f25e 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
cfeaa8f 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
6d8d72d 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
cd1db92 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
4dbfa40 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
c23eea3 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
3a52380 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
ed3432b 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
2c29890 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
a7f38c5 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
6211fa8 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
e594c9b 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
e0b7672 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
88faaa0 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
8313045 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
b8c5dee 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZTS test for O_APPEND
ca12033 
Commit 63b18e4 fixed an issue in zpl_aio_write() to make sure that
kiocb->ki_pos was updated correctly when opening a file with O_APPEND.
Adding a test to verify O_APPEND functionality with lseek can make
sure that all other distros/kernel versions also have the correct
behavior.

Also moved the threadappends_001_pos test into this append test
directory in functional ZTS directory. This way the two append tests
are together for organization purposes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwatkinson @behlendorf