Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Avoid a null pointer dereference in zfs_mount() on FreeBSD #14218

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Bugfix: Avoid a null pointer dereference in zfs_mount() on FreeBSD #14218

merged 1 commit into from
Nov 28, 2022

Conversation

allanjude
Copy link
Contributor

Motivation and Context

Stop FreeBSD Panicing at boot when using ZFS as the root filesystem

Description

When mounting the root filesystem, vfs_t->mnt_vnodecovered is null

This will cause zfsctl_is_node() to dereference a null pointer when mounting, or updating the mount flags, on the root filesystem, both of which happen during the boot process.

Reported-by: Martin Matuska mm@FreeBSD.org
Sponsored-by: Klara, Inc.
Signed-off-by: Allan Jude allan@klarasystems.com

How Has This Been Tested?

Booting FreeBSD in a VM using openzfs.ko (master)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

ryao
ryao suggested changes Nov 23, 2022
View reviewed changes
module/os/freebsd/zfs/zfs_vfsops.c Outdated Show resolved Hide resolved
@allanjude
Bugfix: Avoid a null pointer dereference in zfs_mount() on FreeBSD
06236c5 
When mounting the root filesystem, vfs_t->mnt_vnodecovered is null

This will cause zfsctl_is_node() to dereference a null pointer when
mounting, or updating the mount flags, on the root filesystem, both
of which happen during the boot process.

Reported-by: Martin Matuska <mm@FreeBSD.org>
Sponsored-by: Klara, Inc.
Signed-off-by: Allan Jude <allan@klarasystems.com>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Nov 28, 2022
@behlendorf behlendorf merged commit d27a002 into openzfs:master Nov 28, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 16, 2022
@allanjude @andrewc12
Avoid a null pointer dereference in zfs_mount() on FreeBSD
e5dca10 
When mounting the root filesystem, vfs_t->mnt_vnodecovered is null

This will cause zfsctl_is_node() to dereference a null pointer when
mounting, or updating the mount flags, on the root filesystem, both
of which happen during the boot process.

Reported-by: Martin Matuska <mm@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14218
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 17, 2022
@allanjude @andrewc12
Avoid a null pointer dereference in zfs_mount() on FreeBSD
f43bb3c 
When mounting the root filesystem, vfs_t->mnt_vnodecovered is null

This will cause zfsctl_is_node() to dereference a null pointer when
mounting, or updating the mount flags, on the root filesystem, both
of which happen during the boot process.

Reported-by: Martin Matuska <mm@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14218
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Feb 4, 2023
@allanjude @mmatuska
Avoid a null pointer dereference in zfs_mount() on FreeBSD
e19649d 
When mounting the root filesystem, vfs_t->mnt_vnodecovered is null

This will cause zfsctl_is_node() to dereference a null pointer when
mounting, or updating the mount flags, on the root filesystem, both
of which happen during the boot process.

Reported-by: Martin Matuska <mm@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14218
@mmatuska mmatuska mentioned this pull request Feb 4, 2023
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Feb 6, 2023
@allanjude @behlendorf
Avoid a null pointer dereference in zfs_mount() on FreeBSD
e45a981 
When mounting the root filesystem, vfs_t->mnt_vnodecovered is null

This will cause zfsctl_is_node() to dereference a null pointer when
mounting, or updating the mount flags, on the root filesystem, both
of which happen during the boot process.

Reported-by: Martin Matuska <mm@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes #14218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szubersk szubersk szubersk approved these changes

@amotin amotin amotin approved these changes

@ryao ryao ryao approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allanjude @ryao @amotin @szubersk @behlendorf