-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change zpool email notifications to display the actual pool name instead of the pool GUID #14272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Even though the pool name may not be unique, it is the kind of thing you'd want to see in a human friendly notification.
Might we want to keep the GUID in the email as well though? |
I am inclined to think that we should include the GUID too just in case. |
Outgoing mails for ZFS pool events include the pool GUID, but not the actual pool name. Let's change this for better readability, as it is already done in the mails for finished pool resilvers. Signed-off-by: Marcel Menzel <mail@mcl.gg>
Outgoing mails for ZFS pool events include the pool GUID, but not the actual pool name. Let's change this for better readability, as it is already done in the mails for finished pool resilvers. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Marcel Menzel <mail@mcl.gg> Closes openzfs#14272
Outgoing mails for ZFS pool events include the pool GUID, but not the actual pool name. Let's change this for better readability, as it is already done in the mails for finished pool resilvers. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Marcel Menzel <mail@mcl.gg> Closes openzfs#14272
Outgoing mails for ZFS pool events include the pool GUID, but not the actual pool name. Let's change this for better readability, as it is already done in the mails for finished pool resilvers. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Marcel Menzel <mail@mcl.gg> Closes openzfs#14272
Outgoing mails for ZFS pool events include the pool GUID, but not the actual pool name. Let's change this for better readability, as it is already done in the mails for finished pool resilvers. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Marcel Menzel <mail@mcl.gg> Closes openzfs#14272
Motivation and Context
The current mail for a device / pool state change is printing out the pool GUID instead of the pool name in the email being sent. As a system administrator, I'd like to get a direct idea what is going on, and because I have multiple pools in my system, I don't know which pool just had the said event. (who memorizes pool GUIDs?)
Email notifications for finishing a pool resilver already do this.
Description
Changing zed's
statechange-notify.sh
ZEVENT_POOL_GUID
variable toZEVENT_POOL
.If people like to have the pool GUID aswell, it could be added aswell alongside the pool name. Or make it even configurable, like zed's syslog output (
ZED_SYSLOG_DISPLAY_GUIDS
).How Has This Been Tested?
I applied the patch on one of my machines known to have not 100% reliable disks (with data I have backup-ed elsewhere) and let it run:
Types of changes
Checklist:
Signed-off-by
.