Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console progress reporting for recursive send #14448

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix console progress reporting for recursive send #14448

merged 1 commit into from
Feb 2, 2023

Conversation

ixhamza
Copy link
Member

@ixhamza ixhamza commented Jan 31, 2023

Motivation and Context

After commit 19d3961, progress reporting (-v) with the replication flag enabled does not report the progress on the console. This commit fixes the issue by updating the logic to check for pa->progress instead of pa_verbosity in send_progress_thread().

How Has This Been Tested?

Through different send flags (with progress reporting)

  • zfs send -vL[I]
  • zfs send -vVL
  • zfs send -VL
  • zfs send -vRL
  • zfs send -vVRL
  • zfs send -VRL

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ixhamza
Fix console progress reporting for recursive send
48e35b5 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 31, 2023
ghost
ghost approved these changes Feb 2, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a mess in here but we knew that 😅

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 2, 2023
@behlendorf behlendorf merged commit 05b7241 into openzfs:master Feb 2, 2023
@ghost ghost deleted the fix-recursive-verbose branch February 7, 2023 23:24
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 3, 2023
@ixhamza @lundman
Fix console progress reporting for recursive send
c836dca 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#14448
ixhamza added a commit to truenas/zfs that referenced this pull request Mar 26, 2023
@ixhamza
Fix console progress reporting for recursive send
f16740d 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#14448
ixhamza added a commit to truenas/zfs that referenced this pull request Mar 26, 2023
@ixhamza
Fix console progress reporting for recursive send
123b77b 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#14448
tonyhutter pushed a commit that referenced this pull request Mar 29, 2023
@ixhamza @tonyhutter
Fix console progress reporting for recursive send
184508c 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes #14448
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Mar 29, 2023
@ixhamza @tonyhutter
Fix console progress reporting for recursive send
c63b47e 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#14448
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 5, 2023
@ixhamza @tonyhutter
Fix console progress reporting for recursive send
b38960c 
After commit 19d3961, progress reporting (-v) with replication flag
enabled does not report the progress on the console. This commit
fixes the issue by updating the logic to check for pa->progress
instead of pa_verbosity in send_progress_thread().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#14448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ixhamza @behlendorf