Mtab reads #1498
Closed
Mtab reads #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few lines further down.
reading the file, but instead uses libzfs_mnttab_find() which does any nessesary rewind() for us.
|
@FransUrbo Where do these patches stand? It would be great if they could be refreshed with a clear explanation for why each one is needed and what the patch fixes. |
|
The point was to improve mount speed (see #1484), but they really didn't help that much (cut a few minutes from several hours). So these three just fixes some obvious problems, which is explained quite clearly in the commit message. I'd call these a cleanup and removing some obvious double work on mtab. |
behlendorf
pushed a commit
that referenced
this pull request
Aug 15, 2013
For the same reasons it's used in libzfs_init(), this was just overlooked because zinject gets minimal use. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue #1498
behlendorf
pushed a commit
that referenced
this pull request
Aug 15, 2013
reading the file, but instead use libzfs_mnttab_find() which does the nessesary freopen() for us. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue #1498
behlendorf
pushed a commit
that referenced
this pull request
Aug 15, 2013
a few lines further down and we can share the open file handle. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue #1498
|
Merged |
unya
pushed a commit
to unya/zfs
that referenced
this pull request
Dec 13, 2013
For the same reasons it's used in libzfs_init(), this was just overlooked because zinject gets minimal use. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#1498
unya
pushed a commit
to unya/zfs
that referenced
this pull request
Dec 13, 2013
reading the file, but instead use libzfs_mnttab_find() which does the nessesary freopen() for us. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#1498
unya
pushed a commit
to unya/zfs
that referenced
this pull request
Dec 13, 2013
a few lines further down and we can share the open file handle. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#1498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to find out a nice way to fix #1484, but I only got this far.