Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed DMU_PROJECTUSED_OBJECT prefetch. #15024

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add missed DMU_PROJECTUSED_OBJECT prefetch. #15024

merged 1 commit into from
Jul 13, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Jun 29, 2023 •
edited
Loading

It seems 9c5167d "Project Quota on ZFS" #6290 missed to add prefetch for DMU_PROJECTUSED_OBJECT during scan (scrub/resilver). It should not cause visible problems, but may affect scub/resilver performance.

How Has This Been Tested?

Not really. Just noticed the difference between scan and its prefetch during the code reading.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Add missed DMU_PROJECTUSED_OBJECT prefetch.
9ae2022 
It seems 9c5167d "Project Quota on ZFS" missed to add prefetch
for DMU_PROJECTUSED_OBJECT during scan (scrub/resilver).  It should
not cause visible problems, but may affect scub/resilver performance.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@amotin amotin requested a review from behlendorf June 29, 2023 19:33
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jun 29, 2023
@amotin
Copy link
Member Author

amotin commented Jun 29, 2023

@Nasf-Fan Could you take a look?

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 13, 2023
@behlendorf behlendorf merged commit 6db781d into openzfs:master Jul 13, 2023
@amotin amotin deleted the scan_proj branch July 13, 2023 16:15
amotin added a commit to amotin/zfs that referenced this pull request Jul 13, 2023
@amotin
Add missed DMU_PROJECTUSED_OBJECT prefetch.
79b0df3 
It seems 9c5167d "Project Quota on ZFS" missed to add prefetch
for DMU_PROJECTUSED_OBJECT during scan (scrub/resilver).  It should
not cause visible problems, but may affect scub/resilver performance.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15024
behlendorf pushed a commit that referenced this pull request Jul 20, 2023
@amotin @behlendorf
Add missed DMU_PROJECTUSED_OBJECT prefetch.
b4e630b 
It seems 9c5167d "Project Quota on ZFS" missed to add prefetch
for DMU_PROJECTUSED_OBJECT during scan (scrub/resilver).  It should
not cause visible problems, but may affect scub/resilver performance.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #15024
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@amotin @lundman
Add missed DMU_PROJECTUSED_OBJECT prefetch.
2712cc6 
It seems 9c5167d "Project Quota on ZFS" missed to add prefetch
for DMU_PROJECTUSED_OBJECT during scan (scrub/resilver).  It should
not cause visible problems, but may affect scub/resilver performance.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotin @behlendorf