-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZTS: Add additional exceptions #15306
Merged
behlendorf
merged 1 commit into
openzfs:master
from
behlendorf:disable-zfs_share_concurrent_shares
Sep 25, 2023
Merged
ZTS: Add additional exceptions #15306
behlendorf
merged 1 commit into
openzfs:master
from
behlendorf:disable-zfs_share_concurrent_shares
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, I'll take a look. |
usaleem-ix
approved these changes
Sep 22, 2023
gmelikov
reviewed
Sep 22, 2023
oromenahar
approved these changes
Sep 22, 2023
"zfs_share_concurrent_shares" may fail on FreeBSD and some Linux distributions (fedora). Move it to the common list. "zfs_allow_010_pos" has been observed to fail on FreeBSD 13. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
behlendorf
force-pushed
the
disable-zfs_share_concurrent_shares
branch
from
September 22, 2023 23:42
58d2e16
to
f996586
Compare
behlendorf
changed the title
ZTS: Disable zfs_share_concurrent_shares.sh
ZTS: Add additional exceptions
Sep 22, 2023
gmelikov
approved these changes
Sep 22, 2023
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Sep 25, 2023
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
Sep 26, 2023
"zfs_share_concurrent_shares" may fail on FreeBSD and some Linux distributions (fedora). Move it to the common list. "zfs_allow_010_pos" has been observed to fail on FreeBSD 13. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Umer Saleem <usaleem@ixsystems.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#15306
behlendorf
added a commit
that referenced
this pull request
Sep 28, 2023
"zfs_share_concurrent_shares" may fail on FreeBSD and some Linux distributions (fedora). Move it to the common list. "zfs_allow_010_pos" has been observed to fail on FreeBSD 13. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Umer Saleem <usaleem@ixsystems.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #15306
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
"zfs_share_concurrent_shares" may fail on FreeBSD and some Linux distributions (fedora). Move it to the common list. "zfs_allow_010_pos" has been observed to fail on FreeBSD 13. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Umer Saleem <usaleem@ixsystems.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#15306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Keep the CI as green as possible to make sure no regressions are introduced.
Description
The cli_root/zfs_share/zfs_share_concurrent_shares test case is reliably failing on the Fedora 37 and 38 builders. Disable it.
zfs_allow_010_pos has been observed to fail on FreeBSD 13.
@usaleem-ix this may be of interest since you're currently working in this area of the code.
How Has This Been Tested?
This will be tested by the CI.
Types of changes
Checklist:
Signed-off-by
.