change hardcoded bash completions path in rpm spec

[adamdmoss]

Motivation and Context

Description

This PR attempts to fix or work around #15355 ...

Since approximately eb955f6 a --with-config=srpm build fails like so:

+ /usr/lib/rpm/brp-remove-la-files
Processing files: zfs-2.2.99-308_g621fe1260.x86_64
error: File not found: /tmp/zfs-build-adam-KVjzreNT/BUILDROOT/zfs-2.2.99-308_g621fe1260.x86_64/etc/bash_completion.d/zfs


RPM build errors:
    File not found: /tmp/zfs-build-adam-KVjzreNT/BUILDROOT/zfs-2.2.99-308_g621fe1260.x86_64/etc/bash_completion.d/zfs
make[1]: *** [Makefile:14265: rpm-common] Error 1

This PR hardcodes the new bash completions path into the rpm spec. Dunno if this is the right 'fix' and maybe the way I'm building debs is obsolete (rpm->deb 'alien' conversion) and nobody told me, but here ya go, at least it unbroke builds for me. 😸

I'm guessing that instead of hardcoding either the old location or /usr/share/bash-completion/completions, the .spec.in file should actually be consuming $bashcompletiondir from autoconf (config/zfs-build.m4). But my efforts at making the spec.in 'see' that value have not been successful.

How Has This Been Tested?

Local testing.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[chenxiaolong]

I think this should probably just be:

%{_datadir}/bash-completion/completions

(%{_datadir} expands to /usr/share and since the files live in /usr now, %config(noreplace) should probably be removed so RPM doesn't try to preserve edits.)

[siv0]

This would break building on RHEL and related systems, which do expect bash_completion files in /etc/bash_completion.d

[behlendorf]

Closing in favor of the approach in #15365, thank you both for looking in to this and sorting it out.