-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zpool status: Fix option string, adding -e and fixing order #16008
Conversation
4890cb8
to
86d5832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little bit of OCD on my part, but can you also update zpool-status.8
to also have the options list in alphabetical order as well as part of the PR? They are in line 39 of that file.
86d5832
to
1f76b51
Compare
@bwatkinson, I think I got all the places in |
Cool and thanks. Also can you look into the CI test failures for:
Those seem to reliably fail with this PR. |
1f76b51
to
d3b4ea1
Compare
The recently added '-e' option (PR openzfs#15769) missed adding the new option in the online `zpool status` help command. This adds the options and reorders a couple of the other options that were not listed alphabetically. Signed-off-by: Cameron Harr <harr1@llnl.gov>
d3b4ea1
to
76eaf37
Compare
The recently added '-e' option (PR #15769) missed adding the new option in the online `zpool status` help command. This adds the options and reorders a couple of the other options that were not listed alphabetically. Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Cameron Harr <harr1@llnl.gov> Closes #16008
The recently added '-e' option (PR openzfs#15769) missed adding the new option in the online `zpool status` help command. This adds the options and reorders a couple of the other options that were not listed alphabetically. Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Cameron Harr <harr1@llnl.gov> Closes openzfs#16008
Motivation and Context
Fixes missing
zpool status help
option and alphabetizes the optionsIssue #16004
Description
The recently added '-e' option (PR #15769) missed adding the new option in the online
zpool status
help command. This adds the option and reorders the 'i' and 'D' options alphabetically.How Has This Been Tested?
Test new online help menu:
Before:
After:
Types of changes
Checklist:
Signed-off-by
.Signed-off-by: Cameron Harr harr1@llnl.gov