Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 deprecated python3-distutils #16129

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #16126

Description

As for python-3.12 the distutils package has been deprecated. The latest ax_python_devel.m4 macro from the autoconf archive has been updated accordingly so let's pull in the new version.

We can also drop the changes made to our customized version to continue if the development version is not installed since this functionality has been included upstream.

How Has This Been Tested?

Lightly tested and only with python 3.6.8. The buildbot provides some additional coverage of alternate python versions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

As for python-3.12 the distutils package has been deprecated.
The latest ax_python_devel.m4 macro from the autoconf archive
has been updated accordingly so let's pull in the new version.

We can also drop the changes made to our customized version
to continue if the development version is not installed since
this functionality has been included upstream.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#16126
@behlendorf
Copy link
Contributor Author

@szubersk @rincebrain can you take a look at this.

@tonyhutter tonyhutter mentioned this pull request Apr 25, 2024
13 tasks
Copy link
Contributor

@rincebrain rincebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough to me.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 25, 2024
@behlendorf behlendorf merged commit 317b31e into openzfs:master Apr 25, 2024
23 of 26 checks passed
tonyhutter pushed a commit that referenced this pull request May 2, 2024
As for python-3.12 the distutils package has been deprecated.
The latest ax_python_devel.m4 macro from the autoconf archive
has been updated accordingly so let's pull in the new version.

We can also drop the changes made to our customized version
to continue if the development version is not installed since
this functionality has been included upstream.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #16126
Closes #16129
mmstick pushed a commit to pop-os/zfs-linux that referenced this pull request Jun 14, 2024
ax_python_devel.m4 now checks `sysconfig` (added in 3.2)
before `distutils` (deprecated & removed since 3.12).

See also: openzfs/zfs#16129

Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
As for python-3.12 the distutils package has been deprecated.
The latest ax_python_devel.m4 macro from the autoconf archive
has been updated accordingly so let's pull in the new version.

We can also drop the changes made to our customized version
to continue if the development version is not installed since
this functionality has been included upstream.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#16126
Closes openzfs#16129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants