Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs(4): remove "experimental" from zfs_bclone_enabled #16712

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

robn
Copy link
Member

@robn robn commented Nov 1, 2024

Motivation and Context

If we don't know what we've got by now, we should probably give up and move somewhere nice and without electricity.

Closes #16189.

Description

Remove "experimental", and slightly reword.

How Has This Been Tested?

Just make mancheck.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gmelikov
Copy link
Member

gmelikov commented Nov 1, 2024

Maybe update wording here too

* Enable the experimental block cloning feature. If this setting is 0, then
?

I think we've done enough experiments.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn robn force-pushed the no-more-science-please branch from 0c211d1 to 7cf104d Compare November 1, 2024 10:24
@robn
Copy link
Member Author

robn commented Nov 1, 2024

Maybe update wording here too?

@gmelikov good get, done. Thanks!

@behlendorf behlendorf merged commit 91bd12d into openzfs:master Nov 1, 2024
20 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 5, 2024
I think we've done enough experiments.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#16189 
Closes openzfs#16712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criteria for re-enabling block cloning (toggle zfs_bclone_enabled) by default
4 participants