Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix uClibc for getversion.c #16741

Merged
merged 1 commit into from
Nov 15, 2024
Merged

tests: fix uClibc for getversion.c #16741

merged 1 commit into from
Nov 15, 2024

Conversation

jlsalvador
Copy link
Contributor

This patch fixes compilation with uClibc by applying the same fallback as commit e12d761 to the getversion.c file, which was previously overlooked.

Signed-off-by: José Luis Salvador Rufo salvador.joseluis@gmail.com
Closes #16735

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@jlsalvador
tests: fix uClibc for getversion.c
10d13e0 
This patch fixes compilation with uClibc by applying the same fallback
as commit e12d761 to the `getversion.c`
file, which was previously overlooked.

Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
Closes openzfs#16735
@github-actions github-actions bot added the Status: Work in Progress Not yet ready for general review label Nov 11, 2024
@jlsalvador jlsalvador mentioned this pull request Nov 11, 2024
Closed
@jlsalvador
Copy link
Contributor Author

jlsalvador commented Nov 11, 2024 •
edited
Loading

Tested by me on buildroot using:

  • glibc 2.39-74
  • musl 1.2.5
  • uclibc 1.0.50

behlendorf
behlendorf approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. When you're happy with this please just mark this as ready to review.

@jlsalvador jlsalvador marked this pull request as ready for review November 12, 2024 09:52
@github-actions github-actions bot added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Nov 12, 2024
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 15, 2024
@behlendorf behlendorf merged commit de2e9a5 into openzfs:master Nov 15, 2024
27 of 28 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 15, 2024
@jlsalvador @behlendorf
tests: fix uClibc for getversion.c
2600650 
This patch fixes compilation with uClibc by applying the same fallback
as commit e12d761 to the `getversion.c`
file, which was previously overlooked.
 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
Closes openzfs#16735
Closes openzfs#16741
ixhamza pushed a commit to truenas/zfs that referenced this pull request Dec 2, 2024
@jlsalvador @ixhamza
tests: fix uClibc for getversion.c
c8e6ab5 
This patch fixes compilation with uClibc by applying the same fallback
as commit e12d761 to the `getversion.c`
file, which was previously overlooked.
 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
Closes openzfs#16735
Closes openzfs#16741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenZFS 2.3.0-rc3 & UCLIBC. Crash while compiling. MS_RDONLY = 1
2 participants
@jlsalvador @behlendorf