Fix zpool status deadlock when suspended #2890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following deadlock was possible when a pool was suspended. 1) txg_sync() blockeded in zio_wait() to suspended pool 2) 'zpool export' holds spa_namespace block in txg_wait_synced() 3) 'zpool status/clear' all deadlock on spa_namespace lock To resolve this the POOL_CHECK_SUSPENDED flag is specified when registering the export and destroy handlers. This causes the 'zpool export' command to cleanly fail when run against suspended pool. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#1857
The spa_get_stats() function should never issue IO to the pool when it's suspended. When the pool is suspended the IO will never complete by definition and the caller will block indefinitely. TODO: A cleaner solution for this issue would be the cache the features in the spa. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#1857
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Dec 26, 2014
openzfs#2890 openzfs#2878 Hi, I am trying disk replacement from a single disk zpool and it results to suspended IO and does not allow me to destroy the zpool. Steps to reproduce: create a zpool with single disk (zpool create zp1 /dev/sda) remove the disk zpool status shows disk unavailable insert a new disk zpool replace zp1 /dev/sda /dev/sdb it says "cannot replace /dev/sda with /dev/sdb : pool I/O is currently suspended" The above steps holds good for zpool destroy as well. Now the zpool is unusable and only option for me to destroy zpool is to reboot the system and destroy the old pool and create a new pool. Is there any other option can I try so that I can replace the disk without rebooting the system ? Thanks, Kiran.
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Feb 14, 2015
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Feb 18, 2015
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Mar 1, 2015
|
Closing obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.