Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illumos #1644, #1645, #1646, #1647, #1708 #826

Closed
wants to merge 2 commits into from
Closed

Illumos #1644, #1645, #1646, #1647, #1708 #826

wants to merge 2 commits into from

Conversation

mmatuska
Copy link
Contributor

1644 add ZFS "clones" property
1645 add ZFS "written" and "written@..." properties
1646 "zfs send" should estimate size of stream
1647 "zfs destroy" should determine space reclaimed by destroying multiple snapshots
1708 adjust size of zpool history data
Reviewed by: Richard Lowe richlowe@richlowe.net
Reviewed by: George Wilson gwilson@zfsmail.com
Reviewed by: Albert Lee trisk@opensolaris.org
Approved by: Garrett D'Amore garret@nexenta.com

Ported by: Martin Matuska martin@matuska.org

I have also fixed the 2 issues you reported.
What about moving reguid and the other IOCTL's to the end? This way you keep the backwards compatibility with old ioctls (but may still break with delsnaps, but there is no real choice).

1644 add ZFS "clones" property
1645 add ZFS "written" and "written@..." properties
1646 "zfs send" should estimate size of stream
1647 "zfs destroy" should determine space reclaimed by destroying multiple snapshots
1708 adjust size of zpool history data
Reviewed by: Richard Lowe <richlowe@richlowe.net>
Reviewed by: George Wilson <gwilson@zfsmail.com>
Reviewed by: Albert Lee <trisk@opensolaris.org>
Approved by: Garrett D'Amore <garret@nexenta.com>

Ported by: Martin Matuska <martin@matuska.org>
@behlendorf
Copy link
Contributor

Thanks for the refreshed patch, I'll give it another try.

As for the ioctl reordering, I don't see a great way to deal with it, so I think we'll just have to live with it. I'd rather keep the ioctl's in the same order as the other implementations anyway. We'll just have to let the various Linux distribution maintains know so they can leverage their packaging systems to strongly encourage a reboot.

@behlendorf
Copy link
Contributor

While this patch builds cleanly, and I did a review of the code, when it's applied I'm observing at least one strange issue. The command zpool list no longer shows me all my imported pools instead it displays dashes. Until we run this to ground and get some more testing of this change I can't merge it.

@mmatuska
Copy link
Contributor Author

The problem was in the ioctl order in sys/fs/zfs.h - that file wasn't updated.
As of my current patch, users updating from rc9 should have all ioctl's working (only exception: destroy_snaps, here the arguments have changed)

@behlendorf
Copy link
Contributor

Thanks for running this to ground. I'll queue it up again for further testing with your fix.

pcd1193182 pushed a commit to pcd1193182/zfs that referenced this pull request Sep 26, 2023
When attempting to print chunks/entries (e.g. with `zcachedb logs --index`),
if the `cffi::Slice` can be a direct memory (`Bytes`) reference, then
the binary value of the entries is printed, rather than pretty-printing
them.

This commit provides a better `Debug` implementation for `cffi::Slice`,
which fixes `zcachedb logs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants