Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parent dataset handling in libzfs zfs_rename() #8815

Merged
merged 1 commit into from
May 28, 2019
Merged

Refactor parent dataset handling in libzfs zfs_rename() #8815

merged 1 commit into from
May 28, 2019

Conversation

kusumi
Copy link
Member

@kusumi kusumi commented May 25, 2019

Description

For recursive renaming, simplify the code by moving zhrp and
parentname to inner scope. zhrp is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

How Has This Been Tested?

zfs_rename tests (using -r) have passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@kusumi
Refactor parent dataset handling in libzfs zfs_rename()
0fb0f53 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 25, 2019
@codecov
Copy link

codecov bot commented May 26, 2019 •
edited
Loading

Codecov Report

Merging #8815 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8815      +/-   ##
==========================================
+ Coverage   78.75%   78.82%   +0.07%     
==========================================
  Files         382      382              
  Lines      117809   117805       -4     
==========================================
+ Hits        92776    92856      +80     
+ Misses      25033    24949      -84
Flag Coverage Δ
#kernel 79.29% <ø> (-0.02%) ⬇️
#user 67.59% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e5907...0fb0f53. Read the comment docs.

rlaager
rlaager approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 28, 2019
@behlendorf behlendorf merged commit 5691b86 into openzfs:master May 28, 2019
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 7, 2019
@kusumi @allanjude
Refactor parent dataset handling in libzfs zfs_rename()
2200149 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 15, 2019
@kusumi @allanjude
Refactor parent dataset handling in libzfs zfs_rename()
781b666 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@kusumi @tonyhutter
Refactor parent dataset handling in libzfs zfs_rename()
9b60b10 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@kusumi @tonyhutter
Refactor parent dataset handling in libzfs zfs_rename()
bb16c74 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@kusumi @tonyhutter
Refactor parent dataset handling in libzfs zfs_rename()
4fa744f 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@kusumi @tonyhutter
Refactor parent dataset handling in libzfs zfs_rename()
b57202b 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@kusumi @tonyhutter
Refactor parent dataset handling in libzfs zfs_rename()
9f044b9 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes openzfs#8815
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@kusumi @tonyhutter
Refactor parent dataset handling in libzfs zfs_rename()
e4a11ac 
For recursive renaming, simplify the code by moving `zhrp` and
`parentname` to inner scope. `zhrp` is only used to test existence
of a parent dataset for recursive dataset dir scan since ba6a240.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes #8815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinatale2 dinatale2 dinatale2 approved these changes

@behlendorf behlendorf behlendorf approved these changes

@rlaager rlaager rlaager approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kusumi @rlaager @behlendorf @dinatale2