Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't directly cast unsigned long to void* #9065

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Don't directly cast unsigned long to void* #9065

merged 1 commit into from
Jul 25, 2019

Conversation

kusumi
Copy link
Member

@kusumi kusumi commented Jul 19, 2019

Motivation and Context

Description

Cast to uintptr_t first for portability on integer to/from pointer conversion.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@kusumi
Don't directly cast unsigned long to void*
54274e4 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
@codecov
Copy link

codecov bot commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #9065 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9065      +/-   ##
==========================================
+ Coverage   78.67%    78.7%   +0.02%     
==========================================
  Files         400      400              
  Lines      121009   121009              
==========================================
+ Hits        95199    95235      +36     
+ Misses      25810    25774      -36
Flag Coverage Δ
#kernel 79.57% <100%> (+0.02%) ⬆️
#user 66.56% <ø> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43a8536...54274e4. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 19, 2019
@behlendorf behlendorf requested a review from tonyhutter July 19, 2019 16:32
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 25, 2019
@behlendorf behlendorf merged commit d274ac5 into openzfs:master Jul 25, 2019
allanjude pushed a commit to allanjude/zfs that referenced this pull request Aug 12, 2019
@kusumi @allanjude
Don't directly cast unsigned long to void*
d4e07f2 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
a045061 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
b553c19 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
d861252 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
a91c640 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
cd56665 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
489726c 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
994c33c 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@kusumi @tonyhutter
Don't directly cast unsigned long to void*
4f951b1 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #9065
allanjude pushed a commit to allanjude/zfs that referenced this pull request Oct 13, 2019
@kusumi @allanjude
Don't directly cast unsigned long to void*
acf8bc6 
Cast to uintptr_t first for portability on integer to/from pointer
conversion.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kusumi @behlendorf