Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zvol_wait script should ignore partially received zvols #9260

Merged
merged 1 commit into from
Sep 3, 2019
Merged

zvol_wait script should ignore partially received zvols #9260

merged 1 commit into from
Sep 3, 2019

Conversation

pzakha
Copy link
Contributor

@pzakha pzakha commented Aug 30, 2019

Partially received zvols won't have links in /dev/zvol.

Motivation and Context

The zfs-volume-wait service is timing out when there are partially received zvols since they won't have links and /dev/zvol until the zfs receive has completed. As a matter of fact, I believe block device minor nodes won't even be created for them until then.

Description

While a zfs receive is in-progress for a given zvol, it will have a resume token. However, if a zvol already existed before the receive, it should have a block device minor node and a /dev link. In such a case, the receive will be an incremental receive and there will be an invisible clone at <zvol_name>/%recv for the duration of the receive -- we can check if that dataset exists to determine whether or no the zvol should have a dev link.

How Has This Been Tested?

  • Ran this on a system with partially received zvols, using both incremental and non-incremental partial receives, and made sure that it behaves as expected.
  • Delphix internal testing: ab-pre-push

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Partially received zvols won't have links in /dev/zvol.

Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
@pzakha
Copy link
Contributor Author

pzakha commented Aug 30, 2019

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #9260 into master will decrease coverage by 1.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9260      +/-   ##
==========================================
- Coverage   79.36%   77.83%   -1.53%     
==========================================
  Files         400      389      -11     
  Lines      122035   121562     -473     
==========================================
- Hits        96848    94617    -2231     
- Misses      25187    26945    +1758
Flag Coverage Δ
#kernel 77.43% <ø> (-2.43%) ⬇️
#user 66.11% <ø> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5c1bc...e482b37. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 3, 2019
@behlendorf behlendorf merged commit a91e479 into openzfs:master Sep 3, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#9260
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#9260
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#9260
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#9260
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 19, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#9260
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes openzfs#9260
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
Partially received zvols won't have links in /dev/zvol.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Closes #9260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants