-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zvol_wait script should ignore partially received zvols #9260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially received zvols won't have links in /dev/zvol. Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com>
pcd1193182
approved these changes
Aug 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #9260 +/- ##
==========================================
- Coverage 79.36% 77.83% -1.53%
==========================================
Files 400 389 -11
Lines 122035 121562 -473
==========================================
- Hits 96848 94617 -2231
- Misses 25187 26945 +1758
Continue to review full report at Codecov.
|
sebroy
approved these changes
Sep 3, 2019
behlendorf
approved these changes
Sep 3, 2019
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Sep 3, 2019
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 17, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes openzfs#9260
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes openzfs#9260
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes openzfs#9260
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes openzfs#9260
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 19, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes openzfs#9260
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 23, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes openzfs#9260
tonyhutter
pushed a commit
that referenced
this pull request
Sep 26, 2019
Partially received zvols won't have links in /dev/zvol. Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com> Closes #9260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially received zvols won't have links in /dev/zvol.
Motivation and Context
The
zfs-volume-wait
service is timing out when there are partially received zvols since they won't have links and/dev/zvol
until the zfs receive has completed. As a matter of fact, I believe block device minor nodes won't even be created for them until then.Description
While a zfs receive is in-progress for a given zvol, it will have a resume token. However, if a zvol already existed before the receive, it should have a block device minor node and a /dev link. In such a case, the receive will be an incremental receive and there will be an invisible clone at
<zvol_name>/%recv
for the duration of the receive -- we can check if that dataset exists to determine whether or no the zvol should have a dev link.How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.