Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insert all RSYNC paths in database #221

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 5, 2024

Fix #220

Changes (all for the stage where we insert RSYNC result as Url into database):

  • ignore all directory entries
  • ignore all entries in an /old/ subfolder
  • take into account the book selection which might have been passed
  • display statistics after operation

@benoit74 benoit74 self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 0.76%. Comparing base (59ebd30) to head (51f47f4).

Files Patch % Lines
src/gutenberg2zim/urls.py 0.00% 16 Missing ⚠️
src/gutenberg2zim/entrypoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #221      +/-   ##
========================================
- Coverage   0.76%   0.76%   -0.01%     
========================================
  Files         15      15              
  Lines       1560    1575      +15     
  Branches     336     341       +5     
========================================
  Hits          12      12              
- Misses      1548    1563      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the enhance_urls_creation branch 2 times, most recently from 860a396 to ac101f3 Compare March 7, 2024 15:22
@benoit74 benoit74 marked this pull request as ready for review March 7, 2024 15:24
@benoit74 benoit74 requested a review from rgaudin March 7, 2024 15:24
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; please check my concern before merging

src/gutenberg2zim/urls.py Show resolved Hide resolved
@benoit74 benoit74 merged commit 4ac977c into main Mar 14, 2024
4 of 7 checks passed
@benoit74 benoit74 deleted the enhance_urls_creation branch March 14, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All RSYNC paths are inserted as Url in DB
2 participants