Added Entry::getRedirectEntryIndex() #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 84.63% 84.80% +0.16%
==========================================
Files 98 98
Lines 4314 4316 +2
Branches 1867 1867
==========================================
+ Hits 3651 3660 +9
+ Misses 662 655 -7
Partials 1 1
Continue to review full report at Codecov.
|
veloman-yunkan
force-pushed
the
Entry__getRedirectEntryIndex
branch
3 times, most recently
from
4246d8a
to
52d8fb8
Compare
`Entry::getRedirectEntryIndex()` is functionally equivalent to `Entry::getRedirectEntry().getIndex()`. However, the latter involves access to the dirent of the target entry. When only the index of the target entry is of interest, unnecessarily loading the target dirent may turn sequential disk IO (when iterating entries by their native order) to somewhat random disk IO. The new method is devoid of that drawback.
mgautierfr
force-pushed
the
Entry__getRedirectEntryIndex
branch
from
52d8fb8
to
db4b3e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for openzim/zim-tools#312
Entry::getRedirectEntryIndex()is functionally equivalent toEntry::getRedirectEntry().getIndex(). However, the latter involves access to the dirent of the target entry. When only the index of the target entry is of interest, unnecessarily loading the target dirent may turn sequential disk IO (when iterating entries by their native order) to somewhat random disk IO. The new method is devoid of that drawback.