Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate phet ZIM files #204

Closed
MohitMaliFtechiz opened this issue Mar 2, 2023 · 2 comments · Fixed by #206
Closed

Duplicate phet ZIM files #204

MohitMaliFtechiz opened this issue Mar 2, 2023 · 2 comments · Fixed by #206
Assignees
Milestone

Comments

@MohitMaliFtechiz
Copy link

These two phet ZIM files are same size , same content and ISO code which is return by zim file eng.
https://mirrors.dotsrc.org/kiwix/zim/phet/phet_en-ca_2023-01.zim
https://mirrors.dotsrc.org/kiwix/zim/phet/phet_en-gb_2023-01.zim

Only difference is the file name in my opinion we should not rely on file name rather than metadata and seems like both file are returning same metadata.

@kelson42 kelson42 added the bug label Mar 2, 2023
@kelson42 kelson42 added this to the 2.4.1 milestone Mar 2, 2023
@kelson42
Copy link
Contributor

kelson42 commented Mar 2, 2023

@pavel-karatsiuba To me it sounds logic that they are really similar, because they use almost the same language. But I rediscovered that the metadata Language does not support the country variant... so they have actually the exact same language. I think we should stop for the moment to generate the ZIM files for the languages with Variants. Can you please add a new option --withoutLanguageVariants which basically filter out all the ZIM with language including a Country variant (like en-CA for example).

@pavel-karatsiuba
Copy link
Collaborator

I have made PR with changes. But I think we need to make it in a different way.
This is my proposition: #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants